Skip to content

chore: add internet ckecker before telemetry#2184

Merged
SerhiiOselskyi merged 9 commits intomainfrom
chore/add-internet-ckecker-before-telemetry
Jul 18, 2025
Merged

chore: add internet ckecker before telemetry#2184
SerhiiOselskyi merged 9 commits intomainfrom
chore/add-internet-ckecker-before-telemetry

Conversation

@SerhiiOselskyi
Copy link
Contributor

What/Why/How?

Revert changes for BatchExporter and add internet checker before any interaction with telemetry.

Reference

Testing

Screenshots (optional)

Check yourself

  • Code changed? - Tested with Redoc/Realm/Reunite (internal)
  • All new/updated code is covered by tests
  • New package installed? - Tested in different environments (browser/node)

Security

  • The security impact of the change has been considered
  • Code follows company security practices and guidelines

@SerhiiOselskyi SerhiiOselskyi requested review from a team as code owners July 18, 2025 06:30
@changeset-bot
Copy link

changeset-bot bot commented Jul 18, 2025

⚠️ No Changeset found

Latest commit: e7b9279

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025

Command Mean [ms] Min [ms] Max [ms] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 921.6 ± 9.1 903.9 933.5 1.00
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 1219.0 ± 17.6 1192.8 1246.8 1.32 ± 0.02

Copy link
Contributor

@DmitryAnansky DmitryAnansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left minor comment

@SerhiiOselskyi SerhiiOselskyi merged commit 2632738 into main Jul 18, 2025
37 of 38 checks passed
@SerhiiOselskyi SerhiiOselskyi deleted the chore/add-internet-ckecker-before-telemetry branch July 18, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants