Skip to content

chore: export config constants and refactor exports#2308

Merged
tatomyr merged 1 commit intomainfrom
chore/refactor-exports
Sep 16, 2025
Merged

chore: export config constants and refactor exports#2308
tatomyr merged 1 commit intomainfrom
chore/refactor-exports

Conversation

@tatomyr
Copy link
Copy Markdown
Collaborator

@tatomyr tatomyr commented Sep 16, 2025

What/Why/How?

  • Exported all from config/constants.ts
  • Removed usage of new Config in the code (it's going to be exported only as a type)
  • Regrouped exports for better readability

Check yourself

  • Code changed? - Tested with Redoc/Realm/Reunite (internal)
  • All new/updated code is covered by tests
  • New package installed? - Tested in different environments (browser/node)
  • Documentation update considered

Security

  • The security impact of the change has been considered
  • Code follows company security practices and guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Sep 16, 2025

⚠️ No Changeset found

Latest commit: c8ce059

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 16, 2025

Command Mean [s] Min [s] Max [s] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 1.404 ± 0.016 1.383 1.435 1.00
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 1.405 ± 0.032 1.353 1.457 1.00 ± 0.03

};
});

vi.mock('node:fs', async () => {
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't needed at all.

export * from './load.js';
export * from './utils.js';
export * from './config-resolvers.js';
export * from './constants.js';
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1,6 +1,4 @@
export {
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly moving exports around. No real changes here.

@tatomyr tatomyr marked this pull request as ready for review September 16, 2025 14:39
@tatomyr tatomyr requested a review from a team as a code owner September 16, 2025 14:39
@tatomyr tatomyr force-pushed the chore/refactor-exports branch from 7227e85 to c8ce059 Compare September 16, 2025 15:52
@tatomyr tatomyr merged commit 840edb9 into main Sep 16, 2025
36 checks passed
@tatomyr tatomyr deleted the chore/refactor-exports branch September 16, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants