fix: resolve sibling refs alongside $ref#2362
Merged
Conversation
🦋 Changeset detectedLatest commit: 5a14c1f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
RomanHotsiy
reviewed
Oct 14, 2025
packages/core/src/walk.ts
Outdated
| propType = { name: 'scalar', properties: {} }; | ||
| } | ||
|
|
||
| if (isRef(node[propName]) && type.name === 'Schema' && propType?.name === 'scalar') { |
Member
There was a problem hiding this comment.
we should not hardcode name of the type here
Contributor
Author
There was a problem hiding this comment.
- removed the hardcoded Schema check and now resolve scalar sibling $refs generically
- added a unit test for this case
tatomyr
reviewed
Oct 17, 2025
tatomyr
reviewed
Oct 21, 2025
tatomyr
approved these changes
Oct 21, 2025
vadyvas
changed the title
$ref in Schema contexts
vadyvas
changed the title
JLekawa
reviewed
Oct 22, 2025
JLekawa
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why/How?
Fix handling of description/summary when they are $ref siblings next to a schema $ref so they resolve correctly and override the target schemas.
Why: Previously, bundling left description as a $ref object when used alongside another $ref, matching the bug described in the linked issue.
Reference
Fixes: СLI issue #1907
Testing
Screenshots (optional)
Check yourself
Security