Skip to content

Conversation

@DmitryAnansky
Copy link
Contributor

What/Why/How?

Fixed path-params-defined rule to correctly skip parameters defined via $ref.

Reference

Closes #2457

Testing

Screenshots (optional)

Check yourself

  • Code changed? - Tested with Redoc/Realm/Reunite (internal)
  • All new/updated code is covered by tests
  • New package installed? - Tested in different environments (browser/node)
  • Documentation update considered

Security

  • The security impact of the change has been considered
  • Code follows company security practices and guidelines

@DmitryAnansky DmitryAnansky requested review from a team as code owners December 10, 2025 12:04
@changeset-bot
Copy link

changeset-bot bot commented Dec 10, 2025

🦋 Changeset detected

Latest commit: 4d54030

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@redocly/openapi-core Patch
@redocly/cli Patch
@redocly/respect-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

Command Mean [s] Min [s] Max [s] Relative
redocly lint resources/rebilly.yaml 1.292 ± 0.019 1.263 1.316 1.00
redocly-next lint resources/rebilly.yaml 1.307 ± 0.018 1.279 1.338 1.01 ± 0.02

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 78.69% (🎯 78%) 5910 / 7510
🔵 Statements 78.14% (🎯 78%) 6106 / 7814
🔵 Functions 81.87% (🎯 81%) 1220 / 1490
🔵 Branches 70.75% (🎯 70%) 4069 / 5751
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/core/src/rules/common/path-params-defined.ts 96.42% 93.54% 92.3% 98.14% 103, 116
Generated in workflow #8135 for commit 4d54030 by the Vitest Coverage Report Action

@DmitryAnansky DmitryAnansky merged commit faa5d3c into main Dec 10, 2025
42 checks passed
@DmitryAnansky DmitryAnansky deleted the fix/path-params-defined-for-ref branch December 10, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

$ref to parameters causes error for lint command

4 participants