Skip to content

fix: separator menu item #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Daryna-del merged 1 commit into from
May 30, 2025
Merged

fix: separator menu item #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion @theme/components/Menu/MenuItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ export function MenuItem(props: React.PropsWithChildren<MenuItemProps>): JSX.Ele
});
const telemetry = useTelemetry();
const isDrilldown = type === MenuItemType.DrillDown;
const isSeparator = type === MenuItemType.Separator;
const isNested = type === MenuItemType.Group;
const hasChevron = isNested && !isDrilldown;
const isOperation = type === MenuItemType.Operation;
Expand Down Expand Up @@ -108,6 +109,7 @@ export function MenuItem(props: React.PropsWithChildren<MenuItemProps>): JSX.Ele
deprecated={item.deprecated}
depth={depth}
withChevron={hasChevron}
isSeparator={isSeparator}
onClick={handleOnClick}
ref={labelRef}
role={item.link ? 'none' : 'link'}
Expand Down Expand Up @@ -257,6 +259,7 @@ const MenuItemLabelWrapper = styled.li<{
depth?: number;
withChevron?: boolean;
deprecated?: boolean;
isSeparator?: boolean;
}>`
display: flex;
position: relative;
Expand All @@ -270,10 +273,11 @@ const MenuItemLabelWrapper = styled.li<{
padding: var(--menu-item-label-padding);
gap: var(--menu-item-label-gap);

padding-left: ${({ withChevron, depth }) =>
padding-left: ${({ withChevron, depth, isSeparator }) =>
`calc(
var(--menu-item-padding-horizontal) +
${!withChevron ? 'var(--menu-item-label-chevron-offset)' : '0px'} +
${isSeparator ? 'var(--menu-item-separator-offest)' : '0px'} +
${depth ? 'var(--menu-item-nested-offset) * ' + depth : '0px'}
)`};

Expand Down