-
Notifications
You must be signed in to change notification settings - Fork 81
Moderation update #1512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Moderation update #1512
Conversation
grilledham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked through the code and looks great. Really appreciate the effort you have put into this. I'd be happy for it to merge as is, but I do I have a few comments/thoughts though.
I also didn't test it. Perhaps you can get Tigress to help test it?
|
|
||
| local search_field_name = Gui.uid_name() | ||
|
|
||
| local base_commands = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to generate theses dynamically? Just thinking about maintenance effort to keep this update to date when adding new commands. We should at least be able to get the redmew commands dynamically given we have our own custom module for registering commands, and those are the ones that are most likely to change in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the base ones - not really, for two reasons:
- it is not known if a command is admin only or anyone can run it other than reading it from the official Wiki/testing it out in-game (I did both)
- the command-name/command-help are formatted differently
For RedMew's: yes, it could be posssible to keep it saved in the utils.command module & then have the list automatically populated from registered commands (only needs a few extra formatting steps but really doable)
This PR implements 3 major changes:
ModeratorrankDetailed explanation of each bullet point below.
Changes
1. Addition of Moderator rank
moderatorrank toRanks. Value = 25, between admin(30) and regular(25)2. Rework of core libs to accomodate the new rank
3.A GUIs update
features/gui/info) with all features available: ranks, market, autofill, polls, tasks, shortcuts, paint brush, production HUD, train station teleport, score3.B GUIs extension
Future works
Let me know if anything from the core functionalities/new functionalities needs better explanation or rework