Fix the testsuite of xGEMMTR #1107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make the SRNAME in XERBLA more robust against strings passed from C (e.g. OpenBLAS) - adjust the maximum length of a function name from 6 to 7 characters - add a missing parameter in the error output for z/cgemmtr.
langou
approved these changes
Feb 7, 2025
|
Thanks Martin. This is a great contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing the GEMMTR routine leads to some errors in the test suite, these gets fixed with this PR.
Namely this PR fixes:
make the
SRNAMEinXERBLAmore robust against strings passed from C (e.g. as OpenBLAS does)adjust the maximum length of a function name from 6 to 7 characters to match the length of
xGEMMTR.add a missing parameter in the error output for
c/zgemmtr, causing an error ifc/zgemmtrreturns some wrong dataThe documentation has been updated. Not required
If the PR solves a specific issue, it is set to be closed on merge. Recognized before an issue pops up