Skip to content

fix(tooltip): fix tooltip reopen when mouse leaves #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Theeraphat-Sorasetsakul merged 5 commits into from
Apr 24, 2025
Merged

fix(tooltip): fix tooltip reopen when mouse leaves #1276

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
68c07ce
fix(tooltip): fix tooltip reopen when mouse leaves
Theeraphat-Sorasetsakul Apr 22, 2025
3226433
refactor(tooltip): fix variable and comments
Theeraphat-Sorasetsakul Apr 23, 2025
52992a2
fix(tooltip): fix tooltip reopen when mouse leaves
Theeraphat-Sorasetsakul Apr 24, 2025
32e00d9
docs: rename method and comments
Theeraphat-Sorasetsakul Apr 24, 2025
4bb1664
docs: fix wording
Theeraphat-Sorasetsakul Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/elements/src/tooltip/__test__/tooltip.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,7 @@ describe('tooltip/Tooltip', function () {
});

await elementUpdated(el);
await nextFrame();

expect(tooltip.opened, 'Tooltip is not opened').to.be.true;

Expand All @@ -268,6 +269,7 @@ describe('tooltip/Tooltip', function () {
});

await elementUpdated(el);
await nextFrame();

expect(tooltip.opened, 'Tooltip is not hidden').to.be.false;
}).timeout(MouseMoveDelay * 5);
Expand Down
12 changes: 2 additions & 10 deletions packages/elements/src/tooltip/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,20 +382,12 @@ class Tooltip extends BasicElement {
* Hide tooltip
* @returns {void}
*/
private hideTooltip(): void {
private resetTooltip = (): void => {
this.reset();
this.matchTarget = null;
this.matchTargetRect = null;
this.positionTarget = null;
this.setOpened(false);
}

/**
* Reset tooltip
* @returns {void}
*/
private resetTooltip = (): void => {
this.hideTooltip();
};

/**
Expand Down Expand Up @@ -499,7 +491,7 @@ class Tooltip extends BasicElement {
*/
private onClick = (): void => {
this.clicked = true;
this.hideTooltip();
this.resetTooltip();
};

/**
Expand Down
5 changes: 5 additions & 0 deletions packages/elements/src/tooltip/managers/tooltip-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ class TooltipManager {
* @returns {void}
*/
private onMouseOut = (event: MouseEvent): void => {
this.titleThrottler.task?.cancel();
this.registry.forEach(({ mouseout }) => mouseout(event));
};

Expand All @@ -74,6 +75,7 @@ class TooltipManager {
* @returns {void}
*/
private onMouseLeave = (event: MouseEvent): void => {
this.titleThrottler.task?.cancel();
this.registry.forEach(({ mouseleave }) => mouseleave(event));
};

Expand All @@ -82,6 +84,7 @@ class TooltipManager {
* @returns {void}
*/
private onWheel = (event: WheelEvent): void => {
this.titleThrottler.task?.cancel();
this.registry.forEach(({ wheel }) => wheel(event));
};

Expand All @@ -90,6 +93,7 @@ class TooltipManager {
* @returns {void}
*/
private onKeyDown = (event: KeyboardEvent): void => {
this.titleThrottler.task?.cancel();
this.registry.forEach(({ keydown }) => keydown(event));
};

Expand All @@ -98,6 +102,7 @@ class TooltipManager {
* @returns {void}
*/
private onBlur = (event: FocusEvent): void => {
this.titleThrottler.task?.cancel();
this.registry.forEach(({ blur }) => blur(event));
};

Expand Down
Loading