Remove skip validation setting when inlining constraint #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when inlining a constraint it get created at the same time as the table, so there's never any row to be validated. This makes the `NOT VALID` option a no-op. Since it's a no-op when inlined, it also leads to a diff when doing a schema load from the generated structure.sql, since the `NOT VALID` gets dropped. So let's be pro-active about it, and just get rid of it as soon as the constraint gets inlined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when inlining a constraint it get created at the same time as the table, so there's never any row to be validated. This makes the
NOT VALIDoption a no-op.Since it's a no-op when inlined, it also leads to a diff when doing a schema load from the generated structure.sql, since the
NOT VALIDgets dropped.So let's be pro-active about it, and just get rid of it as soon as the constraint gets inlined.