Skip to content

refactor: remove 'hooks-extra/prefer-use-state-lazy-initialization' from recommended presets #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rel1cx merged 1 commit into from
Mar 20, 2025
Merged

refactor: remove 'hooks-extra/prefer-use-state-lazy-initialization' from recommended presets #1001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/website/content/docs/rules/overview.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ Linter rules can have false positives, false negatives, and some rules are depen
| [`no-unnecessary-use-callback`](./hooks-extra-no-unnecessary-use-callback) | 0️⃣ | Disallow unnecessary usage of `useCallback`. |
| [`no-unnecessary-use-memo`](./hooks-extra-no-unnecessary-use-memo) | 0️⃣ | Disallow unnecessary usage of `useMemo`. |
| [`no-unnecessary-use-prefix`](./hooks-extra-no-unnecessary-use-prefix) | 1️⃣ | Enforces custom Hooks to use at least one other Hook inside. |
| [`prefer-use-state-lazy-initialization`](./hooks-extra-prefer-use-state-lazy-initialization) | 1️⃣ | Enforces function calls made inside `useState` to be wrapped in an `initializer function`. |
| [`prefer-use-state-lazy-initialization`](./hooks-extra-prefer-use-state-lazy-initialization) | 0️⃣ | Enforces function calls made inside `useState` to be wrapped in an `initializer function`. |

## Naming Convention Rules

Expand Down
1 change: 0 additions & 1 deletion packages/plugins/eslint-plugin-react-hooks-extra/src/configs/recommended.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,4 @@ export const name = "react-hooks-extra/recommended";
export const rules = {
"react-hooks-extra/no-direct-set-state-in-use-effect": "warn",
"react-hooks-extra/no-unnecessary-use-prefix": "warn",
"react-hooks-extra/prefer-use-state-lazy-initialization": "warn",
} as const satisfies RulePreset;
6 changes: 0 additions & 6 deletions ...lint-plugin-react-hooks-extra/src/rules/prefer-use-state-lazy-initialization.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,6 @@ react-hooks-extra/prefer-use-state-lazy-initialization
@eslint-react/hooks-extra/prefer-use-state-lazy-initialization
```

**Presets**

- `recommended`
- `recommended-typescript`
- `recommended-type-checked`

## Description

Enforces function calls made inside `useState` to be wrapped in an `initializer function`.
Expand Down
1 change: 1 addition & 0 deletions ...plugins/eslint-plugin-react-hooks-extra/src/rules/prefer-use-state-lazy-initialization.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ function isAllowedName(name: string): boolean {
}

// rule takes inspiration from https://github.com/facebook/react/issues/26520
// TODO: Deprecate this rule when React Compiler is stable enough to be used in production https://github.com/facebook/react/issues/26520#issuecomment-2140795892
export default createRule<[], MessageID>({
meta: {
type: "problem",
Expand Down
1 change: 0 additions & 1 deletion packages/plugins/eslint-plugin/src/configs/recommended.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ export const rules = {
...webApi.rules,
"@eslint-react/hooks-extra/no-direct-set-state-in-use-effect": "warn",
"@eslint-react/hooks-extra/no-unnecessary-use-prefix": "warn",
"@eslint-react/hooks-extra/prefer-use-state-lazy-initialization": "warn",
} as const satisfies RulePreset;

export const plugins = {
Expand Down