Skip to content

refactor: remove unnecessary 'switch (true)' usage #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025
Merged

refactor: remove unnecessary 'switch (true)' usage #1148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 8 additions & 13 deletions packages/plugins/eslint-plugin-react-x/src/rules/no-leaked-conditional-rendering.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,24 +111,19 @@ function inspectVariantTypes(types: ts.Type[]) {
variantTypes.add("nullish");
}
const booleans = types.filter(tsHelpers.isBooleanType);
const boolean0 = booleans[0];
// If incoming type is either "true" or "false", there will be one type
// object with intrinsicName set accordingly
// If incoming type is boolean, there will be two type objects with
// intrinsicName set "true" and "false" each because of ts-api-utils.unionTypeParts()
switch (true) {
case booleans.length === 1 && booleans[0] != null: {
const first = booleans[0];
if (isTrueLiteralType(first)) {
variantTypes.add("truthy boolean");
} else if (isFalseLiteralType(first)) {
variantTypes.add("falsy boolean");
}
break;
}
case booleans.length === 2: {
variantTypes.add("boolean");
break;
if (booleans.length === 1 && boolean0 != null) {
if (isFalseLiteralType(boolean0)) {
variantTypes.add("falsy boolean");
} else if (isTrueLiteralType(boolean0)) {
variantTypes.add("truthy boolean");
}
} else if (booleans.length === 2) {
variantTypes.add("boolean");
}
const strings = types.filter(tsHelpers.isStringType);
if (strings.length > 0) {
Expand Down
Loading