feat: add no-unused-props rule to recommended-type-checked preset, closes #1161
#1178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Rel1cx
changed the title
no-unused-props rule to recommended-type-checked preset, closes #1161
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds the no-unused-props rule to the recommended-type-checked preset configuration, addressing issue #1161. The rule warns about unused component prop declarations and is being enabled with a "warn" severity level.
- Adds
no-unused-propsrule to both eslint-plugin and eslint-plugin-react-x recommended-type-checked configurations - Updates documentation to reflect the rule's inclusion in the recommended-type-checked preset
- Maintains consistency between the two plugin configurations
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/plugins/eslint-plugin/src/configs/recommended-type-checked.ts | Enables the no-unused-props rule with "warn" severity in the main plugin's type-checked preset |
| packages/plugins/eslint-plugin-react-x/src/configs/recommended-type-checked.ts | Enables the no-unused-props rule with "warn" severity in the react-x plugin's type-checked preset |
| packages/plugins/eslint-plugin-react-x/src/rules/no-unused-props.md | Updates documentation to indicate the rule is included in the recommended-type-checked preset |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information