feat(naming-convention/filename): enhance default excepts patterns and improve validation #1185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Add default excepts patterns for common framework files: - Files starting with underscore (_app.tsx, _layout.tsx) - Numeric files (404.tsx) - Square bracket files ([slug].tsx) - Improve validation logic to filter non-word/dash characters - Update documentation with excepts option details - Add comprehensive test cases for new exception patterns This enhances the filename rule to be more framework-agnostic and handles edge cases with special characters in filenames.
Rel1cx
force-pushed
the
feat/filename-rule-enhanced-excepts
branch
from
0f47a76 to
3080de7
Compare
…es/filename.ts Co-authored-by: Copilot <[email protected]> Signed-off-by: REL1CX <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the filename naming convention rule by adding default exception patterns for common framework files and improving validation logic to handle special characters more robustly.
- Adds default exception patterns for framework-specific files like underscore-prefixed files, numeric files, and square bracket files
- Improves validation logic by filtering non-word/dash characters before applying case rules
- Updates documentation with comprehensive examples and framework-specific guidance
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| filename.ts | Adds default exception patterns and improves validation logic with character filtering |
| filename.spec.ts | Adds comprehensive test cases for new exception patterns and edge cases |
| filename.md | Updates documentation with exception option details and framework-specific examples |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/plugins/eslint-plugin-react-naming-convention/src/rules/filename.ts
Show resolved
Hide resolved
packages/plugins/eslint-plugin-react-naming-convention/src/rules/filename.ts
Show resolved
Hide resolved
packages/plugins/eslint-plugin-react-naming-convention/src/rules/filename.md
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enhances the filename rule to be more framework-agnostic and handles edge cases with special characters in filenames.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information