-
-
Notifications
You must be signed in to change notification settings - Fork 32
refactor: reorganize scripts structure and update dependencies #1188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Restructure scripts directory: move lib/ to effects/ and utils/ - Move ignores.ts and version.ts to effects/ directory - Rename glob.ts location from lib/ to utils/ - Update script imports to reflect new directory structure - Update package dependencies across all packages - Regenerate pnpm-lock.yaml with updated dependency tree This change improves the scripts organization by separating effects (side-effect operations) from utilities (pure functions).
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: Copilot <[email protected]> Signed-off-by: REL1CX <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR restructures the scripts directory organization and migrates from vanilla Node.js code to the Effect.js framework for improved functional programming patterns. The refactor separates side-effect operations (moved to effects/) from pure utility functions (moved to utils/), while also updating package dependencies across the project.
- Reorganizes scripts directory structure: moving files from
lib/toeffects/andutils/directories - Migrates scripts to use Effect.js for functional programming with proper error handling and composable effects
- Updates package dependencies including Effect.js, Next.js, Vite, and various ESLint plugins
Reviewed Changes
Copilot reviewed 16 out of 18 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/verify-lockfile.ts | Migrates from vanilla Node.js to Effect.js for git diff command execution |
| scripts/update-version.ts | Refactors to use Effect.js with new imports from reorganized directory structure |
| scripts/update-website.ts | Updates import path from lib/glob to utils/glob |
| scripts/effects/version.ts | New Effect.js implementation for reading and processing VERSION file |
| scripts/effects/ignores.ts | New Effect.js implementation for reading and processing .gitignore file |
| package.json | Adds Effect.js dependencies and updates @swc/core |
| Various example packages | Updates Vite, Next.js, and other dependency versions |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: REL1CX <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: REL1CX <[email protected]>
This change improves the scripts organization by separating effects (side-effect operations) from utilities (pure functions).
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information