refactor: update dom/no-unknown-property rule implementation
#1202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update rule implementation in no-unknown-property.ts - Update rule documentation in no-unknown-property.mdx - Update all config to include latest changes
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the dom/no-unknown-property rule implementation by improving code organization, adding comprehensive TypeScript type annotations, and enhancing documentation.
- Restructures code with clear sections and better organization
- Adds comprehensive TypeScript types and interface definitions
- Improves JSDoc documentation throughout the file
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| no-unknown-property.ts | Complete refactor with TypeScript types, reorganized sections, and improved documentation |
| no-unknown-property.mdx | Removes preset configuration documentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| import { Reporter as RPT } from "@eslint-react/kit"; | ||
| import type { RuleContext, RuleFeature } from "@eslint-react/kit"; | ||
| import { getSettingsFromContext } from "@eslint-react/shared"; | ||
| import type { JSXAttribute } from "@typescript-eslint/types/dist/ast-spec"; |
There was a problem hiding this comment.
The import path uses /dist/ which suggests importing from the compiled output rather than the source. Consider importing from the main entry point: @typescript-eslint/types
Suggested change
| import type { JSXAttribute } from "@typescript-eslint/types/dist/ast-spec"; | |
| import type { JSXAttribute } from "@typescript-eslint/types"; |
packages/plugins/eslint-plugin-react-dom/src/rules/no-unknown-property.ts
Show resolved
Hide resolved
packages/plugins/eslint-plugin-react-dom/src/rules/no-unknown-property.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information