Skip to content

Conversation

@Rel1cx
Copy link
Owner

@Rel1cx Rel1cx commented Sep 1, 2025

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Test
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • I have added a convincing reason for adding this feature, if necessary

Other information

@vercel
Copy link

vercel bot commented Sep 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
eslint-react Building Building Preview Comment Sep 1, 2025 2:28am

@Rel1cx Rel1cx requested a review from Copilot September 1, 2025 02:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the codebase by centralizing duplicate configuration adapter logic into a reusable utility function. The getConfigAdapters utility generates both flat and legacy ESLint configuration adapters for plugins, eliminating code duplication across multiple plugin packages.

Key changes:

  • Created a new getConfigAdapters utility function in the shared package
  • Replaced identical custom adapter functions across 6 plugin packages with the centralized utility
  • Added proper exports and documentation for the new utility

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/shared/src/get-config-adapters.ts New utility function that generates config adapters for ESLint plugins
packages/shared/src/index.ts Exports the new getConfigAdapters utility
packages/shared/docs/functions/getConfigAdapters.md Auto-generated documentation for the new utility function
packages/shared/docs/README.md Updated documentation index to include the new function
packages/plugins/eslint-plugin-react-x/src/index.ts Replaced custom adapter functions with getConfigAdapters utility
packages/plugins/eslint-plugin-react-web-api/src/index.ts Replaced custom adapter functions with getConfigAdapters utility
packages/plugins/eslint-plugin-react-naming-convention/src/index.ts Replaced custom adapter functions with getConfigAdapters utility
packages/plugins/eslint-plugin-react-hooks-extra/src/index.ts Replaced custom adapter functions with getConfigAdapters utility
packages/plugins/eslint-plugin-react-dom/src/index.ts Replaced custom adapter functions with getConfigAdapters utility
packages/plugins/eslint-plugin-react-debug/src/index.ts Replaced custom adapter functions with getConfigAdapters utility

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Rel1cx Rel1cx merged commit 7512014 into 2.0.0 Sep 1, 2025
9 of 10 checks passed
@Rel1cx Rel1cx deleted the refactor/config-adapters branch September 1, 2025 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants