-
-
Notifications
You must be signed in to change notification settings - Fork 32
build: replace tsup with tsdown
#1213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR replaces the tsup build tool with tsdown across the entire monorepo. The migration involves updating configuration files, package dependencies, and build scripts to use the new build tool while maintaining similar configuration options.
- Replace
tsupwithtsdownas the TypeScript build tool - Update all package.json files to use
tsdowndependency instead oftsup - Migrate configuration files from
tsup.config.tstotsdown.config.tswith appropriate API changes
Reviewed Changes
Copilot reviewed 42 out of 45 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/utilities/var/tsup.config.ts | Removed old tsup configuration file |
| packages/utilities/var/tsdown.config.ts | Added new tsdown configuration file |
| packages/utilities/var/package.json | Updated build script and dependency from tsup to tsdown |
| packages/utilities/kit/tsdown.config.ts | Updated import and removed splitting option |
| packages/utilities/kit/package.json | Updated build script and dependency |
| packages/utilities/eff/tsdown.config.ts | Updated import and removed splitting option |
| packages/utilities/eff/package.json | Updated build script and dependency |
| packages/utilities/ast/tsup.config.ts | Removed old tsup configuration file |
| packages/utilities/ast/tsdown.config.ts | Added new tsdown configuration file |
| packages/utilities/ast/package.json | Updated build script and dependency |
| packages/shared/tsup.config.ts | Removed old tsup configuration file |
| packages/shared/tsdown.config.ts | Added new tsdown configuration file |
| packages/shared/package.json | Updated build script and dependency |
| packages/plugins/eslint-plugin/tsup.config.ts | Removed old tsup configuration file |
| packages/plugins/eslint-plugin/tsdown.config.ts | Added new tsdown configuration file |
| packages/plugins/eslint-plugin/package.json | Updated build script and dependency |
| packages/plugins/eslint-plugin-react-x/tsup.config.ts | Removed old tsup configuration file |
| packages/plugins/eslint-plugin-react-x/tsdown.config.ts | Added new tsdown configuration file |
| packages/plugins/eslint-plugin-react-x/package.json | Updated build script and dependency |
| packages/plugins/eslint-plugin-react-web-api/tsup.config.ts | Removed old tsup configuration file |
| packages/plugins/eslint-plugin-react-web-api/tsdown.config.ts | Added new tsdown configuration file |
| packages/plugins/eslint-plugin-react-web-api/package.json | Updated build script and dependency |
| packages/plugins/eslint-plugin-react-naming-convention/tsup.config.ts | Removed old tsup configuration file |
| packages/plugins/eslint-plugin-react-naming-convention/tsdown.config.ts | Added new tsdown configuration file |
| packages/plugins/eslint-plugin-react-naming-convention/package.json | Updated build script and dependency |
| packages/plugins/eslint-plugin-react-hooks-extra/tsdown.config.ts | Updated import and removed splitting option |
| packages/plugins/eslint-plugin-react-hooks-extra/package.json | Updated build script and dependency |
| packages/plugins/eslint-plugin-react-dom/tsdown.config.ts | Updated import and removed splitting option |
| packages/plugins/eslint-plugin-react-dom/package.json | Updated build script and dependency |
| packages/plugins/eslint-plugin-react-debug/tsdown.config.ts | Updated import and removed splitting option |
| packages/plugins/eslint-plugin-react-debug/package.json | Updated build script and dependency |
| packages/core/tsdown.config.ts | Updated import and removed splitting option |
| packages/core/package.json | Updated build script and dependency |
| package.json | Updated root dependencies to include tsdown and remove tsup |
| .pkgs/eslint-plugin-local/tsdown.config.ts | Updated import and removed splitting option |
| .pkgs/eslint-plugin-local/package.json | Updated build script and dependency |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)
packages/utilities/var/tsdown.config.ts:1
- The
splittingoption has been removed from the new configuration but was present in the original tsup config. This inconsistency across packages could lead to different build behaviors. Consider documenting why this option was removed or ensuring consistency across all migrated configs.
import type { Options } from "tsdown";
packages/utilities/kit/tsdown.config.ts:1
- The
splittingoption is being removed from existing configurations during the migration. This represents a behavioral change from the original tsup configuration and should be documented or reviewed to ensure it's intentional.
import type { Options } from "tsdown";
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
1477ef0 to
dcf4810
Compare
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information