feat: update naming convention rules default excepts #1216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the naming convention rules in the eslint-react plugin by enhancing default exception patterns and improving documentation. The changes primarily focus on making the filename rule more flexible for modern web frameworks while removing deprecated functionality.
- Updates default exception patterns to include common framework-specific files (e.g., dynamic routes, underscore prefixed files, numeric files)
- Improves filename validation logic to handle special characters more robustly
- Removes deprecated options and rules while updating documentation with better examples
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| filename.ts | Updates default exceptions and refactors validation logic for better special character handling |
| filename.spec.ts | Adds comprehensive test cases for the new exception patterns and validation behavior |
| filename.mdx | Complete documentation rewrite with modern examples and clearer configuration guidance |
| filename-extension.mdx | Minor heading consistency update |
| component-name.ts | Removes deprecated options from schema |
| component-name.mdx | Updates section heading for consistency |
| no-direct-set-state-in-use-layout-effect.mdx | Removes experimental warning and updates content |
| prefer-namespace-import.mdx | Removes entire file content |
| meta.json | Removes reference to deleted rule |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/plugins/eslint-plugin-react-naming-convention/src/rules/filename.ts
Outdated
Show resolved
Hide resolved
packages/plugins/eslint-plugin-react-naming-convention/src/rules/filename.ts
Outdated
Show resolved
Hide resolved
…es/filename.ts Co-authored-by: Copilot <[email protected]> Signed-off-by: REL1CX <[email protected]>
…es/filename.ts Co-authored-by: Copilot <[email protected]> Signed-off-by: REL1CX <[email protected]>
1 task
This was referenced Sep 15, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information