Skip to content

Conversation

@Rel1cx
Copy link
Owner

@Rel1cx Rel1cx commented Sep 6, 2025

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Test
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • I have added a convincing reason for adding this feature, if necessary

Other information

@Rel1cx Rel1cx requested a review from Copilot September 6, 2025 22:24
@vercel
Copy link

vercel bot commented Sep 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
eslint-react Ready Ready Preview Comment Sep 6, 2025 10:26pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes a bug in the dom/no-string-style-prop ESLint rule to allow string style props on non-host elements (custom React components) while still enforcing the rule for DOM elements.

  • Added a host element check to only enforce the rule on actual DOM elements
  • Added test case to verify custom components can use string style props

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
no-string-style-prop.ts Added host element check to restrict rule enforcement to DOM elements only
no-string-style-prop.spec.ts Added test case validating that custom components can use string style props

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Rel1cx Rel1cx marked this pull request as ready for review September 6, 2025 22:27
@Rel1cx Rel1cx merged commit 5abf842 into 2.0.0 Sep 6, 2025
10 checks passed
@Rel1cx Rel1cx deleted the fix/no-string-style-prop branch September 7, 2025 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants