refactor: rework hooks rules #1225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
…y-use-callback.ts Co-authored-by: Copilot <[email protected]> Signed-off-by: REL1CX <[email protected]>
…direct-set-state-in-use-effect.ts Co-authored-by: Copilot <[email protected]> Signed-off-by: REL1CX <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the hooks rules system by removing support for custom hook aliases and simplifying the core hook detection logic. The changes focus on standardizing hook detection to use built-in React hooks only.
- Removes the
additionalHooksconfiguration and related schemas from settings - Refactors hook detection functions to remove context dependencies and alias support
- Removes deprecated rules and consolidates hook-related functionality
Reviewed Changes
Copilot reviewed 106 out of 107 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/shared/src/settings.ts | Removes custom hooks schema and settings configuration |
| packages/core/src/hook/hook-is.ts | Simplifies hook detection by removing context and alias support |
| packages/plugins/eslint-plugin-react-x/src/rules/*.ts | Updates rules to use simplified hook detection |
| packages/plugins/eslint-plugin-react-hooks-extra/src/rules/*.ts | Removes deprecated rules and updates remaining ones |
| packages/plugins/eslint-plugin-react-hooks-extra/src/plugin.ts | Removes deprecated rule exports |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/plugins/eslint-plugin-react-x/src/rules/prefer-use-state-lazy-initialization.ts
Show resolved
Hide resolved
packages/plugins/eslint-plugin-react-x/src/rules/prefer-use-state-lazy-initialization.ts
Show resolved
Hide resolved
Rel1cx
force-pushed
the
rework/hooks-rules
branch
2 times, most recently
from
4de913a to
66608f5
Compare
Rel1cx
force-pushed
the
rework/hooks-rules
branch
from
66608f5 to
50cada0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information