docs(migration): refine migration table from eslint-plugin-react, closes #1154 #1242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our rule targets anonymous components wrapped in `React.memo`/`forwardRef` and does not flag anonymous default-exported functions (mentioned in docs as `Not supported yet`); context objects are covered by a separate rule; no `ignoreTranspilerName` equivalent - overall not a 1:1 replacement
…rbidden-propsё (supported)
…ing for `react/no-deprecated`.
…/no-deprecated`. Signed-off-by: Eugene <[email protected]>
…-useless-forward-ref` from 🟡 to ✅ Our rule flags forwardRef calls missing the second ref parameter (React.forwardRef and named import); no TS required; semantics match the original rule. Don't get why it was marked as partial Signed-off-by: Eugene <[email protected]>
…/no-unknown-property` from ✅ to 🔧 Our rule provides auto-fixes (meta.fixable: "code"), so it qualifies as "Fully supported with auto-fix" Signed-off-by: Eugene <[email protected]>
…horthand-boolean` from ✅ to 🔧. Our rule provides an automatic fix (meta.fixable: "code"), so it qualifies as "Fully supported with auto-fix". Signed-off-by: Eugene <[email protected]>
…hand-fragment` from ✅ to 🔧 The rule is auto-fixable Signed-off-by: Eugene <[email protected]>
…before-spread`, `no-unnecessary-key` alongside `no-missing-key` Brings parity with `eslint-plugin-react` options (duplicates, key-after-spread, etc.) and makes the migration stricter-by-default Signed-off-by: Eugene <[email protected]>
…d keep Status ❌ There’s no direct replacement; previous link to no-prop-types was unrelated. Signed-off-by: Eugene <[email protected]>
|
@outslept is attempting to deploy a commit to the Rel1cx's projects Team on Vercel. A member of the Team first needs to authorize it. |
outslept
changed the title
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Don't worry about any minor formatting issues. I'll fix them after the PR is merged. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refines the migration documentation table that compares rules from eslint-plugin-react with their ESLint React equivalents. The changes improve accuracy by correcting mappings, status indicators, and adding missing line numbers for better table formatting consistency.
Key changes include:
- Correcting status mappings for several rules (e.g., display-name, forbid-component-props, forward-ref-uses-ref)
- Adding comprehensive rule mappings for jsx-key and no-deprecated rules
- Fixing inconsistent line numbering throughout the table
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: REL1CX <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: REL1CX <[email protected]>
Rel1cx
changed the title
Signed-off-by: Eugene <[email protected]>
Signed-off-by: Eugene <[email protected]>
Contributor
Author
|
Okay. If I've missed something let me know 👀 |
Owner
|
LGTM. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
For most commits, the rationale is already in the PR description; I didn’t duplicate it here.
& WSL kept crashing while editing the docs locally, so I pushed most of my commits via Github's UI. Apologies if there are tiny formatting diffs
Related Issue: #85