Skip to content

Conversation

@Rel1cx
Copy link
Owner

@Rel1cx Rel1cx commented Sep 30, 2025

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Test
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • I have added a convincing reason for adding this feature, if necessary

Other information

@vercel
Copy link

vercel bot commented Sep 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
eslint-react Building Building Preview Comment Sep 30, 2025 7:03pm

@Rel1cx Rel1cx requested a review from Copilot September 30, 2025 19:03
@Rel1cx Rel1cx marked this pull request as ready for review September 30, 2025 19:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables additional ESLint rules in the recommended preset configurations and updates documentation accordingly. It specifically activates the use-state rule for naming conventions and adds a new hook-related rule for direct state setting.

  • Enables @eslint-react/naming-convention/use-state rule in recommended presets
  • Adds @eslint-react/hooks-extra/no-direct-set-state-in-use-effect rule to recommended config
  • Updates documentation to reflect the new preset inclusions

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/plugins/eslint-plugin/src/configs/recommended.ts Adds new hook rule and enables use-state naming convention rule
packages/plugins/eslint-plugin-react-naming-convention/src/rules/use-state.mdx Documents that use-state rule is now included in recommended presets
packages/plugins/eslint-plugin-react-naming-convention/src/configs/recommended.ts Enables use-state rule in naming convention recommended config
apps/website/content/docs/rules/overview.mdx Updates rule status indicator from 0️⃣ to 1️⃣ for use-state rule

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Rel1cx Rel1cx merged commit d4373ab into main Sep 30, 2025
11 of 12 checks passed
@Rel1cx Rel1cx deleted the update-recommended-presets branch September 30, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants