Skip to content

Conversation

@Rel1cx
Copy link
Owner

@Rel1cx Rel1cx commented Oct 1, 2025

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Test
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • I have added a convincing reason for adding this feature, if necessary

Other information

…o-dangerously-set-innerhtml-with-children rule
@vercel
Copy link

vercel bot commented Oct 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
eslint-react Ready Ready Preview Comment Oct 1, 2025 9:39am

@Rel1cx Rel1cx marked this pull request as ready for review October 1, 2025 09:38
@Rel1cx Rel1cx requested a review from Copilot October 1, 2025 09:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the error reporting location in the no-dangerously-set-innerhtml-with-children rule by moving the error marker from the dangerouslySetInnerHTML attribute to the children elements themselves.

  • Simplifies the logic by removing the separate hasChildren function and inlining the children detection
  • Changes the error marker location from dangerouslySetInnerHTML to the actual children
  • Removes the explicit return type annotation from isSignificantChildren function

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Rel1cx Rel1cx changed the title Move error marker from 'dangerouslySetInnerHTML' to children in dom/no-dangerously-set-innerhtml-with-children rule Move error marker from dangerouslySetInnerHTML to children in dom/no-dangerously-set-innerhtml-with-children rule Oct 1, 2025
@Rel1cx Rel1cx merged commit ff59bf3 into main Oct 1, 2025
15 checks passed
@Rel1cx Rel1cx deleted the dom-no-dangerously-set-innerhtml-with-children branch October 1, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants