Refactor getJsxAttribute utility function
#1257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit consolidates attribute lookup functionality by removing the redundant hasJsxAttribute function and improving the getJsxAttribute API. The main changes: - Change getJsxAttribute to accept JSXElement node instead of attributes array - Add JSDoc comments explaining the function purpose and params - Remove the separate hasJsxAttribute function since it can be replaced with getJsxAttribute(ctx, node)(name) != null - Update all usage sites to use the new API - Use consistent "prop" terminology instead of mixing "attribute" and "prop"
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the getJsxAttribute utility function to improve its API design by accepting a JSXElement node instead of an attributes array, while removing the redundant hasJsxAttribute function. The refactor standardizes terminology by consistently using "prop" instead of mixing "attribute" and "prop".
- Changes
getJsxAttributeto accept JSXElement node and automatically extract attributes - Removes
hasJsxAttributefunction since it can be replaced withgetJsxAttribute(ctx, node)(name) != null - Updates all usage sites across multiple rule files to use the simplified API
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/jsx/jsx-attribute.ts | Refactors getJsxAttribute function API and removes hasJsxAttribute |
| packages/plugins/eslint-plugin-react-x/src/rules/no-useless-fragment.ts | Updates to use new getJsxAttribute API |
| packages/plugins/eslint-plugin-react-x/src/rules/no-missing-key.ts | Updates to use new getJsxAttribute API |
| packages/plugins/eslint-plugin-react-x/src/rules/no-implicit-key.ts | Updates to use new getJsxAttribute API |
| packages/plugins/eslint-plugin-react-x/src/rules/no-children-prop.ts | Updates to use new getJsxAttribute API |
| packages/plugins/eslint-plugin-react-dom/src/utils/create-jsx-element-resolver.ts | Updates to use new getJsxAttribute API |
| packages/plugins/eslint-plugin-react-dom/src/rules/no-void-elements-with-children.ts | Updates to use new getJsxAttribute API and terminology |
| packages/plugins/eslint-plugin-react-dom/src/rules/no-unsafe-target-blank.ts | Updates to use new getJsxAttribute API and terminology |
| packages/plugins/eslint-plugin-react-dom/src/rules/no-unsafe-iframe-sandbox.ts | Updates to use new getJsxAttribute API and terminology |
| packages/plugins/eslint-plugin-react-dom/src/rules/no-string-style-prop.ts | Updates to use new getJsxAttribute API and terminology |
| packages/plugins/eslint-plugin-react-dom/src/rules/no-missing-iframe-sandbox.ts | Updates to use new getJsxAttribute API and terminology |
| packages/plugins/eslint-plugin-react-dom/src/rules/no-missing-button-type.ts | Updates to use new getJsxAttribute API |
| packages/plugins/eslint-plugin-react-dom/src/rules/no-dangerously-set-innerhtml.ts | Updates to use new getJsxAttribute API |
| packages/plugins/eslint-plugin-react-dom/src/rules/no-dangerously-set-innerhtml-with-children.ts | Updates to use new getJsxAttribute API |
| packages/core/docs/functions/hasJsxAttribute.md | Removes documentation for deleted hasJsxAttribute function |
| packages/core/docs/functions/getJsxAttribute.md | Updates documentation for new getJsxAttribute API |
| packages/core/docs/README.md | Removes hasJsxAttribute from function list |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/plugins/eslint-plugin-react-x/src/rules/no-useless-fragment.ts
Outdated
Show resolved
Hide resolved
…agment.ts Co-authored-by: Copilot <[email protected]> Signed-off-by: REL1CX <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit consolidates attribute lookup functionality by removing the redundant hasJsxAttribute function and improving the getJsxAttribute API.
The main changes:
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information