Skip to content

Conversation

@Rel1cx
Copy link
Owner

@Rel1cx Rel1cx commented Oct 7, 2025

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Test
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • I have added a convincing reason for adding this feature, if necessary

Other information

@Rel1cx Rel1cx requested a review from Copilot October 7, 2025 16:46
@vercel
Copy link

vercel bot commented Oct 7, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
eslint-react Ready Ready Preview Comment Oct 7, 2025 5:21pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new no-deprecated preset that enables all non-deprecated rules from the x, dom, and web-api presets with error severity. The change consolidates deprecated React functionality rules into a single convenient configuration.

  • Add new no-deprecated preset configuration
  • Refactor settings inheritance to use x.settings instead of dom.settings
  • Update documentation to include the new preset

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/plugins/eslint-plugin/src/index.ts Add import and export for no-deprecated config with documentation comments
packages/plugins/eslint-plugin/src/configs/no-deprecated.ts New configuration file defining deprecated React rules with error severity
packages/plugins/eslint-plugin/src/configs/web-api.ts Update settings to inherit from x config instead of dom
packages/plugins/eslint-plugin/src/configs/recommended.ts Update settings to inherit from x config instead of dom
packages/plugins/eslint-plugin/src/configs/dom.ts Remove settings export to avoid duplication
packages/plugins/eslint-plugin/src/configs/all.ts Update settings to inherit from x config instead of dom
packages/plugins/eslint-plugin/README.md Update branch references in contributing guidelines and license links
apps/website/content/docs/presets.mdx Add documentation for the new no-deprecated preset
apps/website/content/docs/migration.mdx Update migration table formatting and rule reference

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Rel1cx Rel1cx marked this pull request as ready for review October 7, 2025 17:19
@Rel1cx Rel1cx merged commit b784c9a into main Oct 7, 2025
11 of 12 checks passed
@Rel1cx Rel1cx deleted the add-no-deprecated-preset branch October 8, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants