Skip to content

Conversation

Rel1cx
Copy link
Owner

@Rel1cx Rel1cx commented Oct 10, 2025

The changes reorganize the ESLint React plugin configurations by: - Adding strict presets with additional rules enabled - Splitting type-specific rules into separate files - Moving some rules from recommended to strict configs - Properly registering plugins in each config

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Test
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • I have added a convincing reason for adding this feature, if necessary

Other information

The changes reorganize the ESLint React plugin configurations by: -
Adding strict presets with additional rules enabled - Splitting
type-specific rules into separate files - Moving some rules from
recommended to strict configs - Properly registering plugins in each
config
@Rel1cx Rel1cx requested a review from Copilot October 10, 2025 05:24
Copy link

vercel bot commented Oct 10, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
eslint-react Building Building Preview Comment Oct 10, 2025 5:24am

@Rel1cx Rel1cx marked this pull request as ready for review October 10, 2025 05:25
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds strict presets to the react-x and react-dom ESLint plugins, providing more stringent rule configurations beyond the existing recommended presets. The changes reorganize the plugin configurations by extracting TypeScript-specific and type-checking rules into separate modules and introducing new strict configuration variants.

Key changes:

  • Introduction of strict configuration presets for both react-x and react-dom plugins
  • Refactoring of TypeScript and type-checking rules into dedicated modules (_ts.ts, _tc.ts)
  • Migration of certain rules from recommended to strict configurations to maintain backward compatibility

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/plugins/eslint-plugin/src/configs/strict.ts Removes jsx-no-undef rule from strict config
packages/plugins/eslint-plugin/src/configs/dom.ts Removes three rules that are moved to strict config
packages/plugins/eslint-plugin/src/configs/_ts.ts Adds jsx-no-undef rule as disabled for TypeScript
packages/plugins/eslint-plugin-react-x/src/configs/strict.ts Creates new strict configuration with additional rules
packages/plugins/eslint-plugin-react-x/src/configs/strict-typescript.ts Creates TypeScript variant of strict config
packages/plugins/eslint-plugin-react-x/src/configs/strict-type-checked.ts Creates type-checked variant of strict config
packages/plugins/eslint-plugin-react-x/src/configs/recommended.ts Removes multiple rules and adds plugin registration
packages/plugins/eslint-plugin-react-x/src/configs/recommended-typescript.ts Refactors to use shared TypeScript rules module
packages/plugins/eslint-plugin-react-x/src/configs/recommended-type-checked.ts Refactors to use shared type-checking rules module
packages/plugins/eslint-plugin-react-x/src/configs/_ts.ts Creates shared TypeScript-specific rule overrides
packages/plugins/eslint-plugin-react-x/src/configs/_tc.ts Creates shared type-checking rule configurations
packages/plugins/eslint-plugin-react-dom/src/index.ts Registers the new strict configuration
packages/plugins/eslint-plugin-react-dom/src/configs/strict.ts Creates new strict DOM configuration
packages/plugins/eslint-plugin-react-dom/src/configs/recommended.ts Removes rules moved to strict and adds plugin registration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Rel1cx Rel1cx merged commit 70f169d into main Oct 10, 2025
10 of 11 checks passed
@Rel1cx Rel1cx deleted the add-strict-presets-2 branch October 10, 2025 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant