Skip to content

Conversation

Rel1cx
Copy link
Owner

@Rel1cx Rel1cx commented Oct 14, 2025

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Test
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • I have added a convincing reason for adding this feature, if necessary

Other information

Copy link

vercel bot commented Oct 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
eslint-react Ready Ready Preview Comment Oct 14, 2025 9:26am

@Rel1cx Rel1cx requested a review from Copilot October 14, 2025 09:24
@Rel1cx Rel1cx changed the title Remove transform utils and simplify ESLint plugin export Remove remaining items in the unified plugin used for legacy config compatibility and simplify plugin export Oct 14, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Refactor to remove internal transform utilities and streamline the ESLint plugin export by simplifying the rules and typing of configs.

  • Remove unused transform utilities (type-of, transform-keys, pad-keys-left) and their barrel export.
  • Simplify plugin export to only include react-x rules and inline the configs into the exported plugin object.
  • Add a typed ConfigName union and narrow the plugin's configs type.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/plugins/eslint-plugin/src/utils/type-of.ts Removed helper used only by transform utilities.
packages/plugins/eslint-plugin/src/utils/transform-keys.ts Removed key transformation utility.
packages/plugins/eslint-plugin/src/utils/pad-keys-left.ts Removed left-padding keys utility previously used to prefix external plugin rules.
packages/plugins/eslint-plugin/src/utils/index.ts Removed utils barrel export.
packages/plugins/eslint-plugin/src/index.ts Simplified plugin export, narrowed config typing, and removed prefixed external plugin rules from rules.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Rel1cx Rel1cx merged commit faa009e into main Oct 14, 2025
15 checks passed
@Rel1cx Rel1cx deleted the remove-legacy-config-compat-in-unified-plugin branch October 14, 2025 09:29
Rel1cx added a commit that referenced this pull request Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant