Skip to content

Conversation

Rel1cx
Copy link
Owner

@Rel1cx Rel1cx commented Oct 14, 2025

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Test
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • I have added a convincing reason for adding this feature, if necessary

Other information

Copy link

vercel bot commented Oct 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
eslint-react Building Building Preview Comment Oct 14, 2025 6:09pm

@Rel1cx Rel1cx requested a review from Copilot October 14, 2025 18:09
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Refactors plugin helpers by moving URL generation logic from shared utilities into individual plugins. This eliminates the need for centralized helper functions and allows each plugin to handle its own documentation URL generation.

  • Removed the centralized getDocsUrl helper function from the shared package
  • Inlined URL generation logic directly into each plugin's create-rule.ts file
  • Updated file imports and exports to reflect the restructured helpers

Reviewed Changes

Copilot reviewed 9 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/shared/src/settings.ts Updated import path for React version utility
packages/shared/src/index.ts Reorganized exports to remove getDocsUrl and update file references
packages/shared/src/get-doc-url.ts Removed the centralized getDocsUrl helper function
packages/plugins/eslint-plugin-react-x/src/utils/create-rule.ts Added inline getDocsUrl function for react-x plugin
packages/plugins/eslint-plugin-react-web-api/src/utils/create-rule.ts Added inline getDocsUrl function for web-api plugin
packages/plugins/eslint-plugin-react-naming-convention/src/utils/create-rule.ts Added inline getDocsUrl function for naming-convention plugin
packages/plugins/eslint-plugin-react-hooks-extra/src/utils/create-rule.ts Added inline getDocsUrl function for hooks-extra plugin
packages/plugins/eslint-plugin-react-dom/src/utils/create-rule.ts Added inline getDocsUrl function for dom plugin
packages/plugins/eslint-plugin-react-debug/src/utils/create-rule.ts Added inline getDocsUrl function for debug plugin

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Rel1cx Rel1cx merged commit aac97b1 into main Oct 14, 2025
14 of 15 checks passed
@Rel1cx Rel1cx deleted the feat/refactor-plugin-helpers branch October 14, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant