-
-
Notifications
You must be signed in to change notification settings - Fork 27
Add strict preset severity to rules overview, closes #1284 #1285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds strict preset severities to the rules overview documentation and aligns strict config severities for no-children-prop with the docs.
- Elevate no-children-prop to error in strict presets for both plugins.
- Update rules overview tables to show severities for both recommended and strict presets.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
packages/plugins/eslint-plugin/src/configs/strict.ts | Changes no-children-prop from warn to error in the strict preset. |
packages/plugins/eslint-plugin-react-x/src/configs/strict.ts | Changes no-children-prop from warn to error in the strict preset. |
apps/website/content/docs/rules/overview.mdx | Updates legend and tables to display recommended and strict severities for rules. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| [`no-leaked-event-listener`](./web-api-no-leaked-event-listener) | 1️⃣ 1️⃣ | Prevents leaked `addEventListener` in a component or custom hook | | ||
| [`no-leaked-interval`](./web-api-no-leaked-interval) | 1️⃣ 1️⃣ | Prevents leaked `setInterval` in a component or custom hook | | ||
| [`no-leaked-resize-observer`](./web-api-no-leaked-resize-observer) | 1️⃣ 1️⃣ | Prevents leaked `ResizeObserver` in a component or custom hook | | ||
| [`no-leaked-timeout`](./web-api-no-leaked-timeout) | 1️⃣ 1️⃣ | Prevents leaked `setTimeout` in a component or custom hook | |
Copilot
AI
Oct 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] This section uses a single space between severity values while others use double spaces. Please normalize the formatting of dual severities to a single convention across all tables.
| [`no-leaked-event-listener`](./web-api-no-leaked-event-listener) | 1️⃣ 1️⃣ | Prevents leaked `addEventListener` in a component or custom hook | | |
| [`no-leaked-interval`](./web-api-no-leaked-interval) | 1️⃣ 1️⃣ | Prevents leaked `setInterval` in a component or custom hook | | |
| [`no-leaked-resize-observer`](./web-api-no-leaked-resize-observer) | 1️⃣ 1️⃣ | Prevents leaked `ResizeObserver` in a component or custom hook | | |
| [`no-leaked-timeout`](./web-api-no-leaked-timeout) | 1️⃣ 1️⃣ | Prevents leaked `setTimeout` in a component or custom hook | | |
| [`no-leaked-event-listener`](./web-api-no-leaked-event-listener) | 1️⃣ 1️⃣ | Prevents leaked `addEventListener` in a component or custom hook | | |
| [`no-leaked-interval`](./web-api-no-leaked-interval) | 1️⃣ 1️⃣ | Prevents leaked `setInterval` in a component or custom hook | | |
| [`no-leaked-resize-observer`](./web-api-no-leaked-resize-observer) | 1️⃣ 1️⃣ | Prevents leaked `ResizeObserver` in a component or custom hook | | |
| [`no-leaked-timeout`](./web-api-no-leaked-timeout) | 1️⃣ 1️⃣ | Prevents leaked `setTimeout` in a component or custom hook | |
Copilot uses AI. Check for mistakes.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information