Skip to content

Conversation

Rel1cx
Copy link
Owner

@Rel1cx Rel1cx commented Oct 16, 2025

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Test
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • I have added a convincing reason for adding this feature, if necessary

Other information

@Rel1cx Rel1cx requested a review from Copilot October 16, 2025 19:32
Copy link

vercel bot commented Oct 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
eslint-react Ready Ready Preview Comment Oct 16, 2025 7:33pm

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds strict preset severities to the rules overview documentation and aligns strict config severities for no-children-prop with the docs.

  • Elevate no-children-prop to error in strict presets for both plugins.
  • Update rules overview tables to show severities for both recommended and strict presets.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
packages/plugins/eslint-plugin/src/configs/strict.ts Changes no-children-prop from warn to error in the strict preset.
packages/plugins/eslint-plugin-react-x/src/configs/strict.ts Changes no-children-prop from warn to error in the strict preset.
apps/website/content/docs/rules/overview.mdx Updates legend and tables to display recommended and strict severities for rules.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +120 to +123
| [`no-leaked-event-listener`](./web-api-no-leaked-event-listener) | 1️⃣ 1️⃣ | Prevents leaked `addEventListener` in a component or custom hook |
| [`no-leaked-interval`](./web-api-no-leaked-interval) | 1️⃣ 1️⃣ | Prevents leaked `setInterval` in a component or custom hook |
| [`no-leaked-resize-observer`](./web-api-no-leaked-resize-observer) | 1️⃣ 1️⃣ | Prevents leaked `ResizeObserver` in a component or custom hook |
| [`no-leaked-timeout`](./web-api-no-leaked-timeout) | 1️⃣ 1️⃣ | Prevents leaked `setTimeout` in a component or custom hook |
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] This section uses a single space between severity values while others use double spaces. Please normalize the formatting of dual severities to a single convention across all tables.

Suggested change
| [`no-leaked-event-listener`](./web-api-no-leaked-event-listener) | 1️⃣ 1️⃣ | Prevents leaked `addEventListener` in a component or custom hook |
| [`no-leaked-interval`](./web-api-no-leaked-interval) | 1️⃣ 1️⃣ | Prevents leaked `setInterval` in a component or custom hook |
| [`no-leaked-resize-observer`](./web-api-no-leaked-resize-observer) | 1️⃣ 1️⃣ | Prevents leaked `ResizeObserver` in a component or custom hook |
| [`no-leaked-timeout`](./web-api-no-leaked-timeout) | 1️⃣ 1️⃣ | Prevents leaked `setTimeout` in a component or custom hook |
| [`no-leaked-event-listener`](./web-api-no-leaked-event-listener) | 1️⃣ 1️⃣ | Prevents leaked `addEventListener` in a component or custom hook |
| [`no-leaked-interval`](./web-api-no-leaked-interval) | 1️⃣ 1️⃣ | Prevents leaked `setInterval` in a component or custom hook |
| [`no-leaked-resize-observer`](./web-api-no-leaked-resize-observer) | 1️⃣ 1️⃣ | Prevents leaked `ResizeObserver` in a component or custom hook |
| [`no-leaked-timeout`](./web-api-no-leaked-timeout) | 1️⃣ 1️⃣ | Prevents leaked `setTimeout` in a component or custom hook |

Copilot uses AI. Check for mistakes.

@Rel1cx Rel1cx merged commit 99d5224 into main Oct 16, 2025
12 checks passed
@Rel1cx Rel1cx deleted the add-strict-presets-to-rules-overview branch October 16, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant