Skip to content

Conversation

@Rel1cx
Copy link
Owner

@Rel1cx Rel1cx commented Dec 6, 2025

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Test
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • I have added a convincing reason for adding this feature, if necessary

Other information

@vercel
Copy link

vercel bot commented Dec 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
eslint-react Ready Ready Preview Comment Dec 6, 2025 8:21am

@Rel1cx Rel1cx force-pushed the code-optimization-4 branch from 5df486c to 03e7627 Compare December 6, 2025 08:19
@Rel1cx Rel1cx merged commit 4faca53 into main Dec 6, 2025
10 of 11 checks passed
@Rel1cx Rel1cx deleted the code-optimization-4 branch December 6, 2025 08:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to improve documentation formatting across the codebase by standardizing JSDoc comment format. However, the implementation has introduced systematic formatting errors throughout.

Key Changes:

  • Attempted to standardize JSDoc @param tag format by removing hyphens between parameter names and descriptions
  • Added JSDoc comments to previously undocumented functions in packages/core/src/utils/is-react-api.ts
  • Updated generated documentation files to reflect source changes

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 62 comments.

Show a summary per file
File Description
packages/utilities/eff/src/index.ts Updated JSDoc parameter format for multiple utility functions (introduces formatting errors)
packages/utilities/ast/src/function-init-path.ts Updated JSDoc parameter format for function initialization path utilities (introduces formatting errors)
packages/utilities/ast/src/expression-is.ts Updated JSDoc parameter format for expression checking function (introduces formatting errors)
packages/utilities/ast/src/expression-base.ts Updated JSDoc parameter format for expression unwrapping function (introduces formatting errors)
packages/plugins/eslint-plugin-react-x/src/rules/no-string-refs.ts Updated JSDoc parameter format for helper functions (introduces formatting errors)
packages/plugins/eslint-plugin-react-x/src/rules/no-forward-ref.ts Updated JSDoc parameter format for helper functions (introduces formatting errors)
packages/plugins/eslint-plugin-react-dom/src/utils/create-jsx-element-resolver.ts Updated JSDoc parameter format for resolver functions (introduces formatting errors)
packages/plugins/eslint-plugin-react-dom/src/rules/no-unsafe-target-blank.ts Updated JSDoc parameter format for validation functions (introduces formatting errors)
packages/plugins/eslint-plugin-react-dom/src/rules/no-unknown-property.ts Updated JSDoc parameter format for multiple helper functions (introduces formatting errors)
packages/core/src/utils/is-react-api.ts Added documentation for React API checking functions and section comments
packages/core/src/jsx/jsx-stringify.ts Updated JSDoc parameter format (introduces formatting errors)
packages/core/src/jsx/jsx-hierarchy.ts Updated JSDoc parameter format (introduces formatting errors)
packages/core/src/jsx/jsx-element-type.ts Updated JSDoc parameter format (introduces formatting errors)
packages/core/src/jsx/jsx-element-is.ts Updated JSDoc parameter format (introduces formatting errors)
packages/core/src/component/component-name.ts Updated JSDoc parameter format (introduces formatting errors)
packages/core/src/component/component-definition.ts Updated JSDoc parameter format and introduces duplicate @param entries (introduces formatting errors)
packages/core/src/component/component-collector-legacy.ts Updated JSDoc parameter format and introduces duplicate @param entries (introduces formatting errors)
packages/utilities/eff/docs/* Generated documentation files with stray asterisks from source formatting errors
packages/core/docs/* Generated documentation files reflecting source changes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants