Skip to content

refactor: 'no-duplicate-key' and type expression utils #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rel1cx merged 2 commits into from
Dec 29, 2024
Merged

refactor: 'no-duplicate-key' and type expression utils #891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0edd720
refactor: add utility functions for type expressions and refactor 'no…
Rel1cx Dec 29, 2024
1e1093a
refactor: rename 'isTypeOnlyExpression' to 'isTypeExpression'
Rel1cx Dec 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 56 additions & 4 deletions packages/plugins/eslint-plugin-react-debug/src/rules/function-component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1366,6 +1366,62 @@ ruleTester.run(RULE_NAME, rule, {
},
],
},
{
code: /* tsx */ `
const MyComponent1 = (() => null)!;
const MyComponent2 = (() => null)!!;
const MyComponent3 = (() => null)!!! as A;
const MyComponent4 = (() => null)!!! satisfies A;
const MyComponent5 = (() => null)!!! as A satisfies B;
`,
errors: [
{
messageId: "functionComponent",
data: {
name: "MyComponent1",
forwardRef: false,
hookCalls: 0,
memo: false,
},
},
{
messageId: "functionComponent",
data: {
name: "MyComponent2",
forwardRef: false,
hookCalls: 0,
memo: false,
},
},
{
messageId: "functionComponent",
data: {
name: "MyComponent3",
forwardRef: false,
hookCalls: 0,
memo: false,
},
},
{
messageId: "functionComponent",
data: {
name: "MyComponent4",
forwardRef: false,
hookCalls: 0,
memo: false,
},
},
{
messageId: "functionComponent",
data: {
name: "MyComponent5",
forwardRef: false,
hookCalls: 0,
memo: false,
},
},
],
},
],
valid: [
...allFunctions,
Expand All @@ -1375,25 +1431,21 @@ ruleTester.run(RULE_NAME, rule, {
"const results = allSettled.mapLike((x) => (x.status === 'fulfilled' ? format(x.value) : null))",
/* tsx */ `
export const action = (() => {
// ^?
return null;
});
`,
/* tsx */ `
export const action = (() => {
// ^?
return null;
}) as ActionFUnction;
`,
/* tsx */ `
export const action = (() => {
// ^?
return null;
}) satisfies ActionFUnction;
`,
/* tsx */ `
export const action = (() => {
// ^?
return null;
}) as ActionFUnction satisfies ActionFUnction;
`,
Expand Down
2 changes: 1 addition & 1 deletion packages/plugins/eslint-plugin-react-x/src/rules/no-access-state-in-setstate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const RULE_FEATURES = [
export type MessageID = CamelCase<typeof RULE_NAME>;

function getName(node: TSESTree.Expression | TSESTree.PrivateIdentifier): O.Option<string> {
if (node.type === AST_NODE_TYPES.TSAsExpression) {
if (AST.isTypeExpression(node)) {
return getName(node.expression);
}
if (node.type === AST_NODE_TYPES.Identifier || node.type === AST_NODE_TYPES.PrivateIdentifier) {
Expand Down
2 changes: 1 addition & 1 deletion packages/plugins/eslint-plugin-react-x/src/rules/no-direct-mutation-state.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export const RULE_FEATURES = [
export type MessageID = CamelCase<typeof RULE_NAME>;

function getName(node: TSESTree.Expression | TSESTree.PrivateIdentifier): O.Option<string> {
if (node.type === AST_NODE_TYPES.TSAsExpression) {
if (AST.isTypeExpression(node)) {
return getName(node.expression);
}
if (node.type === AST_NODE_TYPES.Identifier || node.type === AST_NODE_TYPES.PrivateIdentifier) {
Expand Down
140 changes: 133 additions & 7 deletions packages/plugins/eslint-plugin-react-x/src/rules/no-duplicate-key.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,19 +17,19 @@ ruleTester.run(RULE_NAME, rule, {
{
messageId: "noDuplicateKey",
data: {
value: '"1"',
value: 'key="1"',
},
},
{
messageId: "noDuplicateKey",
data: {
value: '"1"',
value: 'key="1"',
},
},
{
messageId: "noDuplicateKey",
data: {
value: '"1"',
value: 'key="1"',
},
},
],
Expand All @@ -48,19 +48,19 @@ ruleTester.run(RULE_NAME, rule, {
{
messageId: "noDuplicateKey",
data: {
value: '"1"',
value: 'key="1"',
},
},
{
messageId: "noDuplicateKey",
data: {
value: '"1"',
value: 'key="1"',
},
},
{
messageId: "noDuplicateKey",
data: {
value: '"1"',
value: 'key="1"',
},
},
],
Expand All @@ -75,7 +75,126 @@ ruleTester.run(RULE_NAME, rule, {
{
messageId: "noDuplicateKey",
data: {
value: '"1"',
value: 'key="1"',
},
},
],
},
{
code: /* tsx */ `
const App = () => {
return [1, 2, 3].map((item) => { return <div key="1">{item}</div> })
};
`,
errors: [
{
messageId: "noDuplicateKey",
data: {
value: 'key="1"',
},
},
],
},
{
code: /* tsx */ `
const App = () => {
return nested.map((item) => {
return <div key="1">{item.map((i) => <div key="a">{i}</div>)}</div>
})
};
`,
errors: [
{
messageId: "noDuplicateKey",
data: {
value: 'key="1"',
},
},
{
messageId: "noDuplicateKey",
data: {
value: 'key="a"',
},
},
],
},
{
code: /* tsx */ `
const App = () => {
return nested.map((foo) => {
return <div key="foo">{foo.map((bar) => <div key="bar">{bar.map((baz) => <div key="baz">{baz}</div>)}</div>)}</div>
})
};
`,
errors: [
{
messageId: "noDuplicateKey",
data: {
value: 'key="foo"',
},
},
{
messageId: "noDuplicateKey",
data: {
value: 'key="bar"',
},
},
{
messageId: "noDuplicateKey",
data: {
value: 'key="baz"',
},
},
],
},
{
code: /* tsx */ `
const App = () => {
return nested?.map((foo) => {
return <div key="foo">{foo!.map((bar) => <div key="bar">{bar!!.map(((baz) => <div key="baz">{baz}</div>)!!! as A satisfies B)}</div>)}</div>
})
};
`,
errors: [
{
messageId: "noDuplicateKey",
data: {
value: 'key="foo"',
},
},
{
messageId: "noDuplicateKey",
data: {
value: 'key="bar"',
},
},
{
messageId: "noDuplicateKey",
data: {
value: 'key="baz"',
},
},
],
},
{
code: /* tsx */ `
const App = () => {
return nested.map((foo) => {
return <div key="foo">{foo.notmap((bar) => <div key="bar">{bar.map((baz) => <div key="baz">{baz}</div>)}</div>)}</div>
})
};
`,
errors: [
{
messageId: "noDuplicateKey",
data: {
value: 'key="foo"',
},
},
{
messageId: "noDuplicateKey",
data: {
value: 'key="baz"',
},
},
],
Expand All @@ -102,5 +221,12 @@ ruleTester.run(RULE_NAME, rule, {
return [1, 2, 3].map((item) => { const key = item; return <div key={key}>{item}</div> })
};
`,
/* tsx */ `
const App = () => {
return nested.map((item) => {
return <div key={item}>{item.map((i) => { return <div key={i}>{i}</div> })}</div>
})
};
`,
],
});
Loading
Loading