#9 Split SQL scripts

- all queries in the files are split into separate queries
- each AP has a list of all the queries it needs to evaluate
- all queries from the file are loaded at application startup
- mineor changes in PositiveNUmber formating
- minor fix

Author: OndrejVane

README.md

@@ -1,10 +1,6 @@
-# AntiPatternDetectionApp
-This application was created as part of the thesis. It is used for analysis and detection of anti-patterns in project data.
+# ReliSA - SPADe-Web-GUI
+This application was is used for analysis and detection of anti-patterns in project data.
 
-## Thesis abstract
-The goal of this thesis is to analyze and automatically detect anti-patterns in the data of project management tools using SPADe tools. The SPADe tool is used to collect data from ALM tools and search for bad practices (anti-patterns) in project data. In order to develop this thesis, an analysis of the available anti-patterns was performed and then a subset was selected for further investigation. In the next part, the detection of the analyzed anti-patterns was implemented using SQL queries and Java programming language was used to process the results of these queries. As an extra feature of this thesis, going beyond the scope of the original assignment, a support web application for running the detection process of implemented anti-patters and results presentation was also developed. Furthermore, an experiment was performed on a selected sets of anti-patterns and project data. The success of the detection was verified by comparing the results to those from a manual anti-pattern detection in project data from the source ALM tools. Detection success was successful at 93.65 % compared to manual control.
-
-## Analyzed Anti-Patterns
 In version 1.0.0 of this application, the detection of the following Anti-Patterns is implemented:
 * Business As Usual
 * Long Or Non-Existant Feedback Loops
@@ -14,19 +10,54 @@ In version 1.0.0 of this application, the detection of the following Anti-Patter
 * Too Long Sprint
 * Varying Sprint Length
 
-## Run
-### Tools to run
-It will need the following tools to run the application:
-* Docker
-* Docker Compose
-### Run application
-The following list describes the steps to run (you will need):
-1. Open terminal.
-2. Move to the root folder of this project (AntiPatternDetectionApp).
-3. Build docker images with command `docker-compose build`.
-4. Create and run all containers with command `docker-compose run`.
-5. Open phpMyAdmin on docker address on port 8082.
-6. Create database with name spade using command `CREATE DATABASE spade;`.
-7. Restore database from file `db_dump.sql` located in project root folder.
-8. Run all commands from file `config.sql` located in project root folder.
+# Basic architecture of app
+
+# Installation guide
+
+# Add new Anti-Pattern
+
+# User guide
+## Analyze projects
+1) On home page select project to analyze (you can use check box for select/deselect all projects)
+TODO obrázek
+2) Select Anti-Patterns to analyze (you can use check box for select/deselect all Anti-Patterns)
+TODO obrázek
+3) Click to button Analyze
+TODO obrázek
+4) Table with detections result
+TODO obrázek
+5) Show details of detection
+6) Show detail of Anti-Pattern
+
+## Configuration of Anti-Patterns
+1) Go to Configuration page
+TODO obrázek
+2) Change corresponding threshold values
+TODO obrázek
+3) Click button Save or press Enter
+TODO obrázek
+4) If the values ​​are set correctly, a message is displayed stating that the values ​​were saved successfully
+TODO obrázek
+5) If the values ​​are set incorrectly, a error message is displayed and the corresponding values ​​are highlighted in red with error message
+TODO obrázek
+
+## Show Anti-Pattern detail
+1) Go to Anti-Pattern detail page
+    1) On Home page click on anchor Show next to corresponding Anti-Pattern
+    2) On result page slick on Anti-Pattern name and anchor Detail
+2) Anti-Pattern detail page is shown (name, description, anchor to catalogue, configuration values)
+3) Configuration values can be updated also in this page
+    1) Change corresponding threshold values
+    2) Click button Save or press Enter
+4) If the values ​​are set correctly, a message is displayed stating that the values ​​were saved successfully
+TODO obrázek
+5) If the values ​​are set incorrectly, a error message is displayed and the corresponding values ​​are highlighted in red with error message
+TODO obrázek
+
+## Show project detail
+1) On home page click on anchor Show, next to corresponding project
+TODO obrázek
+2) Project details is shown (project id, name, description) 
+TODO obrázek
+
 

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/detecting/detectors/AntiPatternDetector.java

@@ -12,7 +12,7 @@ public interface AntiPatternDetector {
 
     AntiPattern getAntiPatternModel();
 
-    String getAntiPatternSqlFileName();
+    List<String> getSqlFileNames();
 
     void setSqlQueries(List<String> queries);
 

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/detecting/detectors/BusinessAsUsualDetectorImpl.java

@@ -35,7 +35,11 @@ public class BusinessAsUsualDetectorImpl implements AntiPatternDetector {
             }},
             "Business_As_Usual.md");
 
-    private final String sqlFileName = "business_as_usual.sql";
+    private final List<String> SQL_FILE_NAMES = Arrays.asList(
+            "set_project_id.sql",
+            "select_number_of_iterations.sql",
+            "select_iterations_with_substrings.sql",
+            "select_all_wikipages_that_is_updated_in_iteration.sql");
 
     // sql queries loaded from sql file
     private List<String> sqlQueries;
@@ -54,8 +58,8 @@ public AntiPattern getAntiPatternModel() {
     }
 
     @Override
-    public String getAntiPatternSqlFileName() {
-        return this.sqlFileName;
+    public List<String> getSqlFileNames() {
+        return this.SQL_FILE_NAMES;
     }
 
     @Override

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/detecting/detectors/LongOrNonExistentFeedbackLoopsDetectorImpl.java

@@ -51,7 +51,16 @@ public class LongOrNonExistentFeedbackLoopsDetectorImpl implements AntiPatternDe
             }}
     );
 
-    private final String SQL_FILE_NAME = "long_or_non_existent_feedback_loops.sql";
+    private final List<String> SQL_FILE_NAMES = Arrays.asList(
+            "set_project_id.sql",
+            "select_number_of_iterations.sql",
+            "select_average_iterations_length.sql",
+            "select_number_of_iterations_with_substrings_in_activity.sql",
+            "select_all_activities_with_substrings_and_last_modified_date_as_end_date.sql",
+            "select_project_start_date.sql",
+            "select_project_end_date.sql",
+            "select_all_iterations_that_contains_wikipages_with_substrings.sql");
+
     // sql queries loaded from sql file
     private List<String> sqlQueries;
 
@@ -60,7 +69,7 @@ private float getDivisionOfIterationsWithFeedbackLoop() {
     }
 
     private float getMaxGapBetweenFeedbackLoopRate() {
-        return (float) antiPattern.getConfigurations().get("maxGapBetweenFeedbackLoopRate").getValue();
+        return ((PositiveFloat) antiPattern.getConfigurations().get("maxGapBetweenFeedbackLoopRate").getValue()).floatValue();
     }
 
     private List<String> getSearchSubstringsWithFeedbackLoop() {
@@ -72,9 +81,8 @@ public AntiPattern getAntiPatternModel() {
         return this.antiPattern;
     }
 
-    @Override
-    public String getAntiPatternSqlFileName() {
-        return this.SQL_FILE_NAME;
+    public List<String> getSqlFileNames() {
+        return this.SQL_FILE_NAMES;
     }
 
     @Override
@@ -124,7 +132,7 @@ public QueryResultItem analyze(Project project, DatabaseConnection databaseConne
                     break;
                 case 2:
                     if (rs.size() != 0) {
-                        numberOfIterationsWhichContainsAtLeastOneActivityForFeedback = ((Long) rs.get(0).get("totalCountOfIterationsWithFeedbackActivity")).intValue();
+                        numberOfIterationsWhichContainsAtLeastOneActivityForFeedback = ((Long) rs.get(0).get("totalCountOfIterationsWithSubstringsInActivity")).intValue();
                     }
                     break;
                 case 3:

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/detecting/detectors/NinetyNinetyRuleDetectorImpl.java

@@ -34,16 +34,19 @@ public class NinetyNinetyRuleDetectorImpl implements AntiPatternDetector {
                         new PositiveInteger(2)));
             }});
 
-    private final String sqlFileName = "ninety_ninety_rule.sql";
+    private final List<String> SQL_FILE_NAMES = Arrays.asList(
+            "set_project_id.sql",
+            "select_all_iterations_with_sum_estimated_and_spent_time.sql");
+
     // sql queries loaded from sql file
     private List<String> sqlQueries;
 
     private double getMaxDivisionRange() {
-        return (Double) antiPattern.getConfigurations().get("maxDivisionRange").getValue();
+        return ((PositiveFloat) antiPattern.getConfigurations().get("maxDivisionRange").getValue()).doubleValue();
     }
 
     private int getMaxBadDivisionLimit() {
-        return (int) antiPattern.getConfigurations().get("maxBadDivisionLimit").getValue();
+        return ((PositiveInteger) antiPattern.getConfigurations().get("maxBadDivisionLimit").getValue()).intValue();
     }
 
     @Override
@@ -52,8 +55,8 @@ public AntiPattern getAntiPatternModel() {
     }
 
     @Override
-    public String getAntiPatternSqlFileName() {
-        return this.sqlFileName;
+    public List<String> getSqlFileNames() {
+        return this.SQL_FILE_NAMES;
     }
 
     @Override
@@ -63,11 +66,11 @@ public void setSqlQueries(List<String> queries) {
 
     /**
      * Postup detekce:
-     *      1) pro každou iteraci udělat součet stráveného a odhadovaného času přes všechny aktivity
-     *      2) udělat podíl strávený čas / odhadovaný čas
-     *      3) pokud všechny výsledky podílů budou menší než 1.2 => vše ok
-     *      4) pokud předchozí bod nezabere, tak iterovat přes všechny podíly
-     *      5) pokud budou nalezeny tři iterace po sobě, kde se stále zhoršují odhady => detekováno
+     * 1) pro každou iteraci udělat součet stráveného a odhadovaného času přes všechny aktivity
+     * 2) udělat podíl strávený čas / odhadovaný čas
+     * 3) pokud všechny výsledky podílů budou menší než 1.2 => vše ok
+     * 4) pokud předchozí bod nezabere, tak iterovat přes všechny podíly
+     * 5) pokud budou nalezeny tři iterace po sobě, kde se stále zhoršují odhady => detekováno
      *
      * @param project            analyzovaný project
      * @param databaseConnection databázové připojení

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/detecting/detectors/RoadToNowhereDetectorImpl.java

@@ -44,16 +44,23 @@ public class RoadToNowhereDetectorImpl implements AntiPatternDetector {
             }},
             "Road_To_Nowhere.md");
 
-    private final String sqlFileName = "road_to_nowhere.sql";
+    private final List<String> SQL_FILE_NAMES = Arrays.asList(
+            "set_project_id.sql",
+            "set_first_iteration_start_date.sql",
+            "set_second_iteration_start_date.sql",
+            "set_number_of_activities_with_substrings.sql",
+            "set_number_of_wiki_pages_with_substrings.sql",
+            "select_number_of_activities_and_wiki_pages_with_substrings.sql");
+
     // sql queries loaded from sql file
     private List<String> sqlQueries;
 
     private int getMinNumberOfWikiPagesWithProjectPlan() {
-        return (int) antiPattern.getConfigurations().get("minNumberOfWikiPagesWithProjectPlan").getValue();
+        return ((PositiveInteger) antiPattern.getConfigurations().get("minNumberOfWikiPagesWithProjectPlan").getValue()).intValue();
     }
 
     private int getMinNumberOfActivitiesWithProjectPlan() {
-        return (int) antiPattern.getConfigurations().get("minNumberOfActivitiesWithProjectPlan").getValue();
+        return ((PositiveInteger) antiPattern.getConfigurations().get("minNumberOfActivitiesWithProjectPlan").getValue()).intValue();
     }
 
     private List<String> getSearchSubstringsWithProjectPlan() {
@@ -66,8 +73,8 @@ public AntiPattern getAntiPatternModel() {
     }
 
     @Override
-    public String getAntiPatternSqlFileName() {
-        return this.sqlFileName;
+    public List<String> getSqlFileNames() {
+        return this.SQL_FILE_NAMES;
     }
 
     @Override
@@ -98,8 +105,8 @@ public QueryResultItem analyze(Project project, DatabaseConnection databaseConne
                     Utils.fillQueryWithSearchSubstrings(this.sqlQueries, getSearchSubstringsWithProjectPlan()));
             if (rs != null) {
                 while (rs.next()) {
-                    numberOfIssuesForProjectPlan = rs.getInt("numberOfIssuesForProjectPlan");
-                    numberOfWikiPagesForProjectPlan = rs.getInt("numberOfWikiPagesForProjectPlan");
+                    numberOfIssuesForProjectPlan = rs.getInt("numberOfActivitiesWithSubstrings");
+                    numberOfWikiPagesForProjectPlan = rs.getInt("numberOfWikiPagesWithSubstrings");
                 }
             }
 

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/detecting/detectors/SpecifyNothingDetectorImpl.java

@@ -49,20 +49,26 @@ public class SpecifyNothingDetectorImpl implements AntiPatternDetector {
             }},
             "Specify_Nothing.md");
 
-    private final String sqlFileName = "specify_nothing.sql";
+    private final List<String> SQL_FILE_NAMES = Arrays.asList(
+            "set_project_id.sql",
+            "set_number_of_wiki_pages_with_substrings.sql",
+            "set_number_of_activities_with_substrings.sql",
+            "set_average_length_of_activities_description.sql",
+            "select_statistics_for_given_project.sql");
+
     // sql queries loaded from sql file
     private List<String> sqlQueries;
 
     private int getMinNumberOfWikiPagesWithSpecification() {
-        return (int) antiPattern.getConfigurations().get("minNumberOfWikiPagesWithSpecification").getValue();
+        return ((PositiveInteger) antiPattern.getConfigurations().get("minNumberOfWikiPagesWithSpecification").getValue()).intValue();
     }
 
     private int getMinNumberOfActivitiesWithSpecification() {
-        return (int) antiPattern.getConfigurations().get("minNumberOfActivitiesWithSpecification").getValue();
+        return ((PositiveInteger) antiPattern.getConfigurations().get("minNumberOfActivitiesWithSpecification").getValue()).intValue();
     }
 
     private int getMinAvgLengthOfActivityDescription() {
-        return (int) antiPattern.getConfigurations().get("minAvgLengthOfActivityDescription").getValue();
+        return ((PositiveInteger) antiPattern.getConfigurations().get("minAvgLengthOfActivityDescription").getValue()).intValue();
     }
 
     private List<String> getSearchSubstringsWithProjectSpecification() {
@@ -75,8 +81,8 @@ public AntiPattern getAntiPatternModel() {
     }
 
     @Override
-    public String getAntiPatternSqlFileName() {
-        return this.sqlFileName;
+    public List<String> getSqlFileNames() {
+        return this.SQL_FILE_NAMES;
     }
 
     @Override
@@ -110,8 +116,8 @@ public QueryResultItem analyze(Project project, DatabaseConnection databaseConne
                     Utils.fillQueryWithSearchSubstrings(this.sqlQueries, getSearchSubstringsWithProjectSpecification()));
             if (rs != null) {
                 while (rs.next()) {
-                    numberOfWikiPages = rs.getInt("numberOfWikiPages");
-                    numberOfActivitiesForSpecification = rs.getInt("numberOfActivitiesForSpecification");
+                    numberOfWikiPages = rs.getInt("numberOfWikiPagesWithSubstrings");
+                    numberOfActivitiesForSpecification = rs.getInt("numberOfActivitiesWithSubstrings");
                     averageLengthOfIssueDescription = rs.getDouble("averageLengthOfIssueDescription");
                 }
             }

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/detecting/detectors/TooLongSprintDetectorImpl.java

@@ -6,10 +6,7 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import java.util.ArrayList;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
+import java.util.*;
 
 public class TooLongSprintDetectorImpl implements AntiPatternDetector {
 
@@ -37,7 +34,12 @@ public class TooLongSprintDetectorImpl implements AntiPatternDetector {
             }}
     );
 
-    private final String SQL_FILE_NAME = "too_long_sprint.sql";
+    private final List<String> SQL_FILE_NAMES = Arrays.asList(
+            "set_project_id.sql",
+            "set_first_iteration_id.sql",
+            "set_last_iteration_id.sql",
+            "select_all_iterations_with_lengths_without_first_and_last.sql");
+
     // sql queries loaded from sql file
     private List<String> sqlQueries;
 
@@ -47,21 +49,22 @@ public AntiPattern getAntiPatternModel() {
     }
 
     @Override
-    public String getAntiPatternSqlFileName() {
-        return this.SQL_FILE_NAME;
+    public List<String> getSqlFileNames() {
+        return this.SQL_FILE_NAMES;
     }
 
+
     @Override
     public void setSqlQueries(List<String> queries) {
         this.sqlQueries = queries;
     }
 
     private Integer getMaxIterationLength(){
-        return (Integer) this.antiPattern.getConfigurations().get("maxIterationLength").getValue();
+        return ((PositiveInteger) this.antiPattern.getConfigurations().get("maxIterationLength").getValue()).intValue();
     }
 
     private Integer getMaxNumberOfTooLongIterations(){
-        return (Integer) this.antiPattern.getConfigurations().get("maxNumberOfTooLongIterations").getValue();
+        return ((PositiveInteger) this.antiPattern.getConfigurations().get("maxNumberOfTooLongIterations").getValue()).intValue();
     }
 
     /**