Drop support for gcc < 13 and ruby < 3.0#188
Conversation
* .github/workflows/fuzzr.yml:
* .github/workflows/linux.yml:
* README.adoc:
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughCI infrastructure updated to use Ubuntu 24.04 with GCC 13+ as default toolchain, including introduction of configurable make flags in the Linux workflow matrix. Prerequisite documentation updated to reflect the new minimum compiler version requirements (GCC 13+, Ruby 3.0+). Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/fuzzr.yml (1)
30-35:⚠️ Potential issue | 🟡 MinorUpdate Ruby version for consistency with other workflows.
ubuntu-slimis a valid GitHub-hosted runner label (currently in public preview), so the job will start correctly. However, Ruby 2.7 is inconsistent with the Ruby versions used in other workflows (3.0, 3.1, 3.2). Consider updating to Ruby 3.0 or later to align with the rest of the codebase.
🤖 Fix all issues with AI agents
In @.github/workflows/linux.yml:
- Line 132: The brix11 invocation places ${{ matrix.make_flags }} before the
last two make commands so the flags are treated as the command name; move the
flags to after each make target invocation. Update the command so each segment
reads like "make -N <target> -- ${{ matrix.make_flags }}" for the
TAOX11_ROOT/examples, TAOX11_ROOT/orbsvcs/tests and TAOX11_ROOT/tests targets
(keeping $X11_BASE_ROOT and the initial make segment unchanged) so flags are
passed correctly to make.
In `@README.adoc`:
- Line 21: Update the README.adoc entry that currently reads "ruby 3.0 through
3.1.2" to reflect the tested Ruby versions by changing it to "ruby 3.0 through
3.2"; locate the table cell containing the string "ruby 3.0 through 3.1.2" and
replace it so the documented range matches the CI matrix.
| |========================================= | ||
| |Prerequisite |Package name | ||
| |ruby 2.5 through 3.1.2 |ruby | ||
| |ruby 3.0 through 3.1.2 |ruby |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Find and check README.adoc around line 21
echo "=== Checking README.adoc ==="
if [ -f "README.adoc" ]; then
sed -n '15,30p' README.adoc
else
echo "README.adoc not found in root"
fi
# Find CI workflow files
echo -e "\n=== Finding CI workflow files ==="
find .github/workflows -name "*.yml" -o -name "*.yaml" 2>/dev/null | head -20Repository: RemedyIT/axcioma
Length of output: 694
🏁 Script executed:
#!/bin/bash
# Check for linux.yml or similar CI workflow
echo "=== Looking for linux workflow ==="
ls -la .github/workflows/ 2>/dev/null || echo "No .github/workflows directory"
# Also search for any reference to Ruby version in workflow files
echo -e "\n=== Searching for Ruby version refs in workflows ==="
rg -i "ruby" .github/workflows/ --max-count=20 2>/dev/nullRepository: RemedyIT/axcioma
Length of output: 1559
🏁 Script executed:
#!/bin/bash
# Get the full linux.yml content to see the matrix definition
echo "=== Full linux.yml content ==="
cat .github/workflows/linux.ymlRepository: RemedyIT/axcioma
Length of output: 4998
Update README.adoc to reflect tested Ruby versions.
The Linux CI matrix tests Ruby 3.2, but the README caps the documented range at 3.1.2. Update the README to ruby 3.0 through 3.2 to match what the CI actually validates.
🤖 Prompt for AI Agents
In `@README.adoc` at line 21, Update the README.adoc entry that currently reads
"ruby 3.0 through 3.1.2" to reflect the tested Ruby versions by changing it to
"ruby 3.0 through 3.2"; locate the table cell containing the string "ruby 3.0
through 3.1.2" and replace it so the documented range matches the CI matrix.
Summary by CodeRabbit
Release Notes
Documentation
Chores