fix: content crops on PDF export preview on mozilla based browsers#43
Open
whitesideofthesun wants to merge 1 commit intoRenovamen:mainfrom
Open
fix: content crops on PDF export preview on mozilla based browsers#43whitesideofthesun wants to merge 1 commit intoRenovamen:mainfrom
whitesideofthesun wants to merge 1 commit intoRenovamen:mainfrom
Conversation
heridotlife
added a commit
to heridotlife/oh-my-cv
that referenced
this pull request
Dec 23, 2025
- Merge upstream PRs Renovamen#29, Renovamen#33, Renovamen#36, Renovamen#37, Renovamen#38, Renovamen#39, Renovamen#41, Renovamen#42, Renovamen#43 - Upgrade project dependencies - Update README with credits to original author - Fix build issues: - Resolve circular dependencies in composables/stores - Fix YAML syntax in FR translation - Add theme_color to PWA manifest - Increase Vite chunk size warning limit - Update browserslist/caniuse-lite - Temporarily disable web fonts to prevent build timeouts
heridotlife
added a commit
to heridotlife/oh-my-cv
that referenced
this pull request
Dec 23, 2025
- Merge upstream PRs Renovamen#29, Renovamen#33, Renovamen#36, Renovamen#37, Renovamen#38, Renovamen#39, Renovamen#41, Renovamen#42, Renovamen#43 - Upgrade project dependencies - Update README with credits to original author - Fix build issues: - Resolve circular dependencies in composables/stores - Fix YAML syntax in FR translation - Add theme_color to PWA manifest - Increase Vite chunk size warning limit - Update browserslist/caniuse-lite - Temporarily disable web fonts to prevent build timeouts - Disable Nuxt DevTools to resolve dev server crash
heridotlife
added a commit
to heridotlife/oh-my-cv
that referenced
this pull request
Dec 23, 2025
- Merge upstream PRs Renovamen#29, Renovamen#33, Renovamen#36, Renovamen#37, Renovamen#38, Renovamen#39, Renovamen#41, Renovamen#42, Renovamen#43 - Upgrade project dependencies - Bump version to 0.1.2 - Update README and repo references to heridotlife/oh-my-cv - Add Indonesian and Japanese translations (i18n) - Fix build issues: - Resolve circular dependencies in composables/stores - Fix YAML syntax in FR translation - Add theme_color to PWA manifest - Increase Vite chunk size warning limit - Update browserslist/caniuse-lite - Temporarily disable web fonts to prevent build timeouts - Disable Nuxt DevTools to resolve dev server crash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR Fixes #34
When printing resumes in Firefox, using
height: 100vhon page elements causes content to be cropped at the bottom. This occurs because:100vhrefers to the browser viewport height, which may be smaller than the actual paper size (e.g., A4 ≈ 1123px at 96dpi)Solution
Use
height: autoalong withmin-height: 100vhinstead ofheight: 100vhfor page elements in print mode.Since
#resume-previewhasheight: auto(content-based), this allows elements to grow with content.Testing
Screenshots