Drop Python 3.9 support, require Python 3.10+#698
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary of ChangesHello @yarikoptic, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project's Python compatibility, moving to a minimum requirement of Python 3.10. This change streamlines development by leveraging newer language features and ensures alignment with current Python ecosystem standards. All references and configurations across the codebase, documentation, and build processes have been adjusted to reflect this updated dependency. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly drops support for Python 3.9 and sets the minimum required version to 3.10. All related changes in the Dockerfile, documentation, and pyproject.toml are consistent with this goal. I have one suggestion for a potential follow-up improvement related to this version bump.
| name = "neurodocker" | ||
| readme = "README.md" | ||
| requires-python = ">=3.9" | ||
| requires-python = ">=3.10" |
There was a problem hiding this comment.
With Python 3.10 as the new minimum version, it's a good opportunity to review the usage of the typing-extensions dependency. Some features provided by typing-extensions for older Python versions (like TypeGuard and ParamSpec) are available in the standard typing module in Python 3.10. You might be able to simplify your code by using the native implementations and potentially remove the typing-extensions dependency if it's no longer providing unique functionality for your project.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #698 +/- ##
==========================================
- Coverage 88.06% 88.02% -0.04%
==========================================
Files 11 11
Lines 1039 1044 +5
==========================================
+ Hits 915 919 +4
- Misses 124 125 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
precommit was broken elsewhere but let's fix here since it is minor. |
=== Do not change lines below ===
{
"chain": [],
"cmd": "pre-commit run --files .github/workflows/release.yml || :",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
|
pre commit is happy now |
Labeling to release to test docker container generation