Skip to content

XFAIL 2 centos7 based tests of tracer#634

Merged
yarikoptic merged 1 commit intomasterfrom
bf-test-centos
Sep 5, 2025
Merged

XFAIL 2 centos7 based tests of tracer#634
yarikoptic merged 1 commit intomasterfrom
bf-test-centos

Conversation

@yarikoptic
Copy link
Member

No description provided.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @yarikoptic, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses persistent failures in CentOS 7-based tests by marking them as expected to fail (xfail) or disabling specific assertions. This ensures that the continuous integration pipeline can proceed without being blocked by issues stemming from external, defunct infrastructure, specifically the mirrorlist.centos.org domain.

Highlights

  • Test xfail for CentOS 7 test_distribution: The test_distribution function, which targets CentOS 7, has been marked with @pytest.mark.xfail. This is due to the mirrorlist.centos.org domain no longer being available, causing the test to fail.
  • Disabled assertions in test_tracer for CentOS 7: Specific assertions related to source_ids within the test_tracer function have been commented out for CentOS 7. This change is linked to the broader issue of CentOS 7 test failures, aligning with the xfail applied to test_distribution.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request marks two CentOS 7 based tests as expected to fail, which is appropriate given that the mirrorlist.centos.org for CentOS 7 is no longer available. While test_distribution is correctly updated with a pytest.mark.xfail decorator, the test_tracer test has assertions commented out. My review focuses on improving the maintainability of test_tracer by using pytest.mark.xfail consistently, rather than commenting out code, to clearly track known issues.

@ReproNim ReproNim deleted a comment from gemini-code-assist bot Sep 5, 2025
@yarikoptic yarikoptic merged commit 20f6543 into master Sep 5, 2025
2 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant