-
Notifications
You must be signed in to change notification settings - Fork 8
Update fsl.md #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update fsl.md #416
Conversation
Added CDE table
✅ Deploy Preview for repronim ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @seanhatton, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This PR updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request has been reviewed and the following comments have been provided to help improve the code.
| | FSL\_code | Region of interest | | ||
| | :---- | :---- | | ||
| | fsl\_000001 | Background (voxels) | | ||
| | fsl\_000002 | Background (volume) | | ||
| | fsl\_000003 | Left-Accumbens-area (voxels) | | ||
| | fsl\_000004 | Left-Accumbens-area (volume) | | ||
| | fsl\_000005 | Left-Amygdala (voxels) | | ||
| | fsl\_000006 | Left-Amygdala (volume) | | ||
| | fsl\_000007 | Left-Caudate (voxels) | | ||
| | fsl\_000008 | Left-Hippocampus (volume) | | ||
| | fsl\_000009 | Left-Pallidum (voxels) | | ||
| | fsl\_000010 | Left-Putamen (volume) | | ||
| | fsl\_000011 | Left-Thalamus-Proper (voxels) | | ||
| | fsl\_000012 | Right-Accumbens-area (volume) | | ||
| | fsl\_000013 | Left-Putamen (voxels) | | ||
| | fsl\_000014 | Left-Putamen (volume) | | ||
| | fsl\_000015 | Left-Thalamus-Proper (voxels) | | ||
| | fsl\_000016 | Left-Thalamus-Proper (volume) | | ||
| | fsl\_000017 | Right-Accumbens-area (voxels) | | ||
| | fsl\_000018 | Right-Accumbens-area (volume) | | ||
| | fsl\_000019 | Right-Amygdala (voxels) | | ||
| | fsl\_000020 | Right-Amygdala (volume) | | ||
| | fsl\_000021 | Right-Caudate (voxels) | | ||
| | fsl\_000022 | Right-Hippocampus (volume) | | ||
| | fsl\_000023 | Right-Pallidum (voxels) | | ||
| | fsl\_000024 | Right-Putamen (volume) | | ||
| | fsl\_000025 | Right-Thalamus-Proper (voxels) | | ||
| | fsl\_000026 | Right-Accumbens-area (volume) | | ||
| | fsl\_000027 | Right-Putamen (voxels) | | ||
| | fsl\_000028 | Right-Putamen (volume) | | ||
| | fsl\_000029 | Right-Thalamus-Proper (voxels) | | ||
| | fsl\_000030 | Right-Thalamus-Proper (volume) | | ||
| | fsl\_000031 | csf (voxels) | | ||
| | fsl\_000032 | csf (mm^3) | | ||
| | fsl\_000033 | gray (voxels) | | ||
| | fsl\_000034 | gray (mm^3) | | ||
| | fsl\_000035 | white (voxels) | | ||
| | fsl\_000036 | white (mm^3) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CDE table contains significant errors that make it unreliable and confusing for users. I've identified two main issues:
-
Incorrect and Incomplete Data: The table has numerous duplicated entries, missing entries, and incorrectly ordered regions. This makes the mapping between
FSL_codeand the region of interest incorrect.- Several regions are missing their
(voxels)or(volume)counterparts (e.g.,Left-Caudate,Left-Hippocampus). - There are duplicate entries for regions like
Left-Putamen,Left-Thalamus-Proper,Right-Accumbens-area,Right-Putamen, andRight-Thalamus-Proper. - The ordering is illogical, with right-hemisphere regions appearing amidst left-hemisphere regions.
- Several regions are missing their
-
Inconsistent Units: The table uses
(volume)as a unit for most regions, but(mm^3)forcsf,gray, andwhitematter. To be clear and consistent, it's better to use a specific unit likemm^3for all volume measurements.
I've reconstructed the table to address these issues, assuming a logical pairing and ordering of regions. Please review and apply the suggested correction.
| FSL\_code | Region of interest |
| :---- | :---- |
| fsl\_000001 | Background (voxels) |
| fsl\_000002 | Background (mm^3) |
| fsl\_000003 | Left-Accumbens-area (voxels) |
| fsl\_000004 | Left-Accumbens-area (mm^3) |
| fsl\_000005 | Left-Amygdala (voxels) |
| fsl\_000006 | Left-Amygdala (mm^3) |
| fsl\_000007 | Left-Caudate (voxels) |
| fsl\_000008 | Left-Caudate (mm^3) |
| fsl\_000009 | Left-Hippocampus (voxels) |
| fsl\_000010 | Left-Hippocampus (mm^3) |
| fsl\_000011 | Left-Pallidum (voxels) |
| fsl\_000012 | Left-Pallidum (mm^3) |
| fsl\_000013 | Left-Putamen (voxels) |
| fsl\_000014 | Left-Putamen (mm^3) |
| fsl\_000015 | Left-Thalamus-Proper (voxels) |
| fsl\_000016 | Left-Thalamus-Proper (mm^3) |
| fsl\_000017 | Right-Accumbens-area (voxels) |
| fsl\_000018 | Right-Accumbens-area (mm^3) |
| fsl\_000019 | Right-Amygdala (voxels) |
| fsl\_000020 | Right-Amygdala (mm^3) |
| fsl\_000021 | Right-Caudate (voxels) |
| fsl\_000022 | Right-Caudate (mm^3) |
| fsl\_000023 | Right-Hippocampus (voxels) |
| fsl\_000024 | Right-Hippocampus (mm^3) |
| fsl\_000025 | Right-Pallidum (voxels) |
| fsl\_000026 | Right-Pallidum (mm^3) |
| fsl\_000027 | Right-Putamen (voxels) |
| fsl\_000028 | Right-Putamen (mm^3) |
| fsl\_000029 | Right-Thalamus-Proper (voxels) |
| fsl\_000030 | Right-Thalamus-Proper (mm^3) |
| fsl\_000031 | csf (voxels) |
| fsl\_000032 | csf (mm^3) |
| fsl\_000033 | gray (voxels) |
| fsl\_000034 | gray (mm^3) |
| fsl\_000035 | white (voxels) |
| fsl\_000036 | white (mm^3) |
Added CDE table