Skip to content

Conversation

seanhatton
Copy link
Contributor

Added CDE table

Added CDE table
@netlify
Copy link

netlify bot commented Oct 8, 2025

Deploy Preview for repronim ready!

Name Link
🔨 Latest commit f2c5b74
🔍 Latest deploy log https://app.netlify.com/projects/repronim/deploys/68e69e4c9944bc0008628800
😎 Deploy Preview https://deploy-preview-416--repronim.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @seanhatton, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This PR updates the fsl.md documentation by adding a comprehensive table of FSL Common Data Elements (CDEs). The new section maps FSL codes to specific brain regions and tissue types, indicating whether the measurement is in voxels or volume, thereby improving the clarity and completeness of the FSL tutorial.

Highlights

  • Intent: This pull request aims to enhance the fsl.md documentation by adding a new section that details the FSL Common Data Elements (CDEs). The goal is to provide a clear mapping between FSL codes and their corresponding regions of interest, making the documentation more comprehensive and easier to understand for users.
  • Changes: The pull request modifies a single file: content/resources/tutorials/fsl.md. A new section titled '## FSL Common Data Elements' has been appended to the file. This section includes a Markdown table that lists 36 entries, mapping specific FSL_code values (e.g., fsl_000001 to fsl_000036) to their respective 'Region of interest' (e.g., 'Background (voxels)', 'Left-Accumbens-area (volume)', 'csf (mm^3)', 'white (voxels)'). The table provides a detailed breakdown of FSL codes for various brain regions and tissue types, indicating whether the value represents voxels or volume.
  • Reviewer Activity: No specific reviewer activity has been recorded or provided for this pull request.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request has been reviewed and the following comments have been provided to help improve the code.

Comment on lines +72 to +109
| FSL\_code | Region of interest |
| :---- | :---- |
| fsl\_000001 | Background (voxels) |
| fsl\_000002 | Background (volume) |
| fsl\_000003 | Left-Accumbens-area (voxels) |
| fsl\_000004 | Left-Accumbens-area (volume) |
| fsl\_000005 | Left-Amygdala (voxels) |
| fsl\_000006 | Left-Amygdala (volume) |
| fsl\_000007 | Left-Caudate (voxels) |
| fsl\_000008 | Left-Hippocampus (volume) |
| fsl\_000009 | Left-Pallidum (voxels) |
| fsl\_000010 | Left-Putamen (volume) |
| fsl\_000011 | Left-Thalamus-Proper (voxels) |
| fsl\_000012 | Right-Accumbens-area (volume) |
| fsl\_000013 | Left-Putamen (voxels) |
| fsl\_000014 | Left-Putamen (volume) |
| fsl\_000015 | Left-Thalamus-Proper (voxels) |
| fsl\_000016 | Left-Thalamus-Proper (volume) |
| fsl\_000017 | Right-Accumbens-area (voxels) |
| fsl\_000018 | Right-Accumbens-area (volume) |
| fsl\_000019 | Right-Amygdala (voxels) |
| fsl\_000020 | Right-Amygdala (volume) |
| fsl\_000021 | Right-Caudate (voxels) |
| fsl\_000022 | Right-Hippocampus (volume) |
| fsl\_000023 | Right-Pallidum (voxels) |
| fsl\_000024 | Right-Putamen (volume) |
| fsl\_000025 | Right-Thalamus-Proper (voxels) |
| fsl\_000026 | Right-Accumbens-area (volume) |
| fsl\_000027 | Right-Putamen (voxels) |
| fsl\_000028 | Right-Putamen (volume) |
| fsl\_000029 | Right-Thalamus-Proper (voxels) |
| fsl\_000030 | Right-Thalamus-Proper (volume) |
| fsl\_000031 | csf (voxels) |
| fsl\_000032 | csf (mm^3) |
| fsl\_000033 | gray (voxels) |
| fsl\_000034 | gray (mm^3) |
| fsl\_000035 | white (voxels) |
| fsl\_000036 | white (mm^3) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The CDE table contains significant errors that make it unreliable and confusing for users. I've identified two main issues:

  1. Incorrect and Incomplete Data: The table has numerous duplicated entries, missing entries, and incorrectly ordered regions. This makes the mapping between FSL_code and the region of interest incorrect.

    • Several regions are missing their (voxels) or (volume) counterparts (e.g., Left-Caudate, Left-Hippocampus).
    • There are duplicate entries for regions like Left-Putamen, Left-Thalamus-Proper, Right-Accumbens-area, Right-Putamen, and Right-Thalamus-Proper.
    • The ordering is illogical, with right-hemisphere regions appearing amidst left-hemisphere regions.
  2. Inconsistent Units: The table uses (volume) as a unit for most regions, but (mm^3) for csf, gray, and white matter. To be clear and consistent, it's better to use a specific unit like mm^3 for all volume measurements.

I've reconstructed the table to address these issues, assuming a logical pairing and ordering of regions. Please review and apply the suggested correction.

| FSL\_code | Region of interest |
| :---- | :---- |
| fsl\_000001 | Background (voxels) |
| fsl\_000002 | Background (mm^3) |
| fsl\_000003 | Left-Accumbens-area (voxels) |
| fsl\_000004 | Left-Accumbens-area (mm^3) |
| fsl\_000005 | Left-Amygdala (voxels) |
| fsl\_000006 | Left-Amygdala (mm^3) |
| fsl\_000007 | Left-Caudate (voxels) |
| fsl\_000008 | Left-Caudate (mm^3) |
| fsl\_000009 | Left-Hippocampus (voxels) |
| fsl\_000010 | Left-Hippocampus (mm^3) |
| fsl\_000011 | Left-Pallidum (voxels) |
| fsl\_000012 | Left-Pallidum (mm^3) |
| fsl\_000013 | Left-Putamen (voxels) |
| fsl\_000014 | Left-Putamen (mm^3) |
| fsl\_000015 | Left-Thalamus-Proper (voxels) |
| fsl\_000016 | Left-Thalamus-Proper (mm^3) |
| fsl\_000017 | Right-Accumbens-area (voxels) |
| fsl\_000018 | Right-Accumbens-area (mm^3) |
| fsl\_000019 | Right-Amygdala (voxels) |
| fsl\_000020 | Right-Amygdala (mm^3) |
| fsl\_000021 | Right-Caudate (voxels) |
| fsl\_000022 | Right-Caudate (mm^3) |
| fsl\_000023 | Right-Hippocampus (voxels) |
| fsl\_000024 | Right-Hippocampus (mm^3) |
| fsl\_000025 | Right-Pallidum (voxels) |
| fsl\_000026 | Right-Pallidum (mm^3) |
| fsl\_000027 | Right-Putamen (voxels) |
| fsl\_000028 | Right-Putamen (mm^3) |
| fsl\_000029 | Right-Thalamus-Proper (voxels) |
| fsl\_000030 | Right-Thalamus-Proper (mm^3) |
| fsl\_000031 | csf (voxels) |
| fsl\_000032 | csf (mm^3) |
| fsl\_000033 | gray (voxels) |
| fsl\_000034 | gray (mm^3) |
| fsl\_000035 | white (voxels) |
| fsl\_000036 | white (mm^3) |

@memartone memartone requested a review from dnkennedy October 21, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant