feat: improve cookiecutter reliability and testing infrastructure #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ties - Update Activity1 schema from 1.0.0-rc4 to 1.0.0 - Remove all hardcoded activity references from protocol template - Enhance update_schema_version.py with better error handling and array context support - Remove non-existent Activity4 reference This allows the post-generation hook to dynamically populate activities based on user selection.
- Add logging infrastructure for better debugging - Implement retry logic for GitHub API calls with exponential backoff - Add caching mechanism for UI checksum (1-hour validity) - Improve error messages with specific exception types - Make pre-commit installation optional with informative messages - Add cleanup for temporary files - Return proper exit codes on failure
- Create requirements.txt with pinned dependencies - Add comprehensive pyproject.toml with project metadata - Configure pre-commit hooks for code quality - Include development, validation, and documentation dependencies - Set up linting rules (ruff, black, mypy, bandit) - Add local hook for automatic schema version updates
- Add comprehensive PR template with checklist - Include sections for description, testing, and validation - Ensure schema version consistency checks - Add reminders for documentation updates
- Add internal/ folder to prevent committing internal documentation - Add temporary files used during cookiecutter generation - Include .ui_checksum_cache and selected_activities.json
- Add GitHub Actions workflow for testing cookiecutter generation - Test across multiple OS (Ubuntu, Windows, macOS) and Python versions - Validate generated project structure and JSON schemas - Add workflow for testing generated projects functionality - Create local test script for development verification - Ensure proper activity count and no hardcoded references - Add schema version consistency checks
- Fix escaped quotes in post_gen_project.py docstring - Add run_in_env.sh helper script to gitignore - Helper script provides easy access to micromamba environment
- Rename all activity schema files to lowercase (e.g., activity2_schema) - Update post_gen_project.py to use lowercase filenames consistently - Normalize prefLabel to always use object notation with language tags - Fix path references to match actual filenames This ensures consistency with ReproSchema naming conventions and prevents path mismatch errors when loading activities.
- Update context path from /contexts/generic to /contexts/reproschema for v1.0.0 - Fix @id values to match lowercase filenames (e.g., activity2_schema) - Update schema version script to handle different context paths by version - All schemas now validate successfully with reproschema validate command This ensures compatibility with ReproSchema 1.0.0 specification and proper validation.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements comprehensive improvements to the reproschema-protocol-cookiecutter based on analysis from multiple specialized agents (schema-architect, devops-automation-engineer, quality-assurance-engineer).
Major Changes
1. Schema Consistency & Structure
/contexts/genericto/contexts/reproschemafor v1.0.0activity2_schema)2. Error Handling & Reliability
3. Testing Infrastructure
reproschema validatecommand4. Project Infrastructure
5. Development Experience
Test Results
All tests pass successfully:
reproschema validateValidation Example
Breaking Changes
None - all changes are backward compatible.
Next Steps
Future improvements to consider in follow-up PRs:
Testing Instructions
./run_in_env.sh python test_cookiecutter.py(or use micromamba directly)cookiecutter . --no-inputreproschema validate <schema_path>🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]