repo cleaning #13
repo cleaning #13
Conversation
- Add protection for local MCP configurations (.mcp.json) that may contain API keys - Ignore Claude Code settings directory (.claude/) - Exclude test output directories and temporary files - Prevent accidental commits of development artifacts and cache files - Improve repository security and reduce bloat from untracked files Security improvements: - Block sensitive configuration files with potential credentials - Exclude local development tool configurations - Ignore test outputs and cache files that shouldn't be versioned
Summary of ChangesHello @yibeichan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a repository health check by updating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request cleans up the repository by adding several entries to the .gitignore file. The changes mostly ignore local configuration, test outputs, and cache files, which is good practice. However, I've raised a concern about ignoring a Python script (validate_yaml.py) and a workflow file (test-workflow.yml), as these might be essential for other developers and should potentially be version-controlled. Please review the comment for details.
| test-workflow.yml | ||
| validate_yaml.py |
There was a problem hiding this comment.
Ignoring test-workflow.yml and validate_yaml.py can cause issues for other contributors if these files are part of the project's tooling and not generated artifacts.
test-workflow.yml: If this is a GitHub Actions workflow, it should be version-controlled (usually in.github/workflows/) to ensure CI/CD pipelines work for everyone.validate_yaml.py: Python scripts that are part of the development toolchain should be committed to the repository. Ignoring this file could lead to a broken development environment for others who need this script for validation tasks.
If these files are not meant to be shared and are generated locally, then this change is correct. Otherwise, they should be removed from .gitignore and committed to the repository.
repo health check, removed unnecessary files/folders