Skip to content

Conversation

@djarecka
Copy link
Member

@djarecka djarecka commented Jan 31, 2025

Fixing test after changes to #81

  • I fixed the printing error in the test
  • I change parse_html to avoid problem with joining words/lines without space

There are still issues with isVis, from original isVis set to False, after both transfromation, the isVis is set to True. I believe the redcap csv is fine, so the redcap2rs has problem.
You can check in the test tmpdir for example in output_nimh/nimh_minimal/activities/DSM5_crosscutting_adult/DSM5_crosscutting_adult_schema, elemnts like items/dsm5crossad_d_1

EDIT
I added some version of fix, by reverting #81 and removing nan from entire df

@djarecka djarecka mentioned this pull request Jan 31, 2025
@djarecka djarecka changed the title [wip] fixing test_rs2redcap_redcap2rs fixing test_rs2redcap_redcap2rs and reverting some changes to converters Jan 31, 2025
@yibeichan
Copy link
Contributor

yibeichan commented Feb 1, 2025

oh sorry, i figured what you mean

@yibeichan
Copy link
Contributor

in my current redcap2reproschema.py, i can get correct isVis

{
                "isAbout": "items/dsm5crossad_d_1",
                "isVis": false,
                "valueRequired": true,
                "variableName": "dsm5crossad_d_1"
            },
            {
                "isAbout": "items/dsm5crossad_d_2",
                "isVis": false,
                "valueRequired": true,
                "variableName": "dsm5crossad_d_2"
            },
            {
                "isAbout": "items/dsm5crossad_d_3",
                "isVis": false,
                "valueRequired": true,
                "variableName": "dsm5crossad_d_3"
            },
            {
                "isAbout": "items/dsm5crossad_d_4",
                "isVis": false,
                "valueRequired": true,
                "variableName": "dsm5crossad_d_4"
            },
            {
                "isAbout": "items/dsm5crossad_d_5",
                "isVis": false,
                "valueRequired": true,
                "variableName": "dsm5crossad_d_5"
            },
            {
                "isAbout": "items/dsm5crossad_d_6",
                "isVis": false,
                "valueRequired": true,
                "variableName": "dsm5crossad_d_6"
            },
            {
                "isAbout": "items/dsm5crossad_d_7",
                "isVis": false,
                "valueRequired": true,
                "variableName": "dsm5crossad_d_7"
            },
            {
                "isAbout": "items/dsm5crossad_d_8",
                "isVis": false,
                "valueRequired": true,
                "variableName": "dsm5crossad_d_8"
            },
            {
                "isAbout": "items/dsm5crossad_d_9",
                "isVis": false,
                "valueRequired": true,
                "variableName": "dsm5crossad_d_9"
            },
            {
                "isAbout": "items/dsm5crossad_d_10",
                "isVis": false,
                "valueRequired": true,
                "variableName": "dsm5crossad_d_10"
            },
            {
                "isAbout": "items/dsm5crossad_d_11",
                "isVis": false,
                "valueRequired": true,
                "variableName": "dsm5crossad_d_11"
            },
            {
                "isAbout": "items/dsm5crossad_d_12",
                "isVis": false,
                "valueRequired": true,
                "variableName": "dsm5crossad_d_12"
            },
            {
                "isAbout": "items/dsm5crossad_d_13",
                "isVis": false,
                "valueRequired": true,
                "variableName": "dsm5crossad_d_13"
            }
        ],
        "shuffle": false

yibeichan added a commit to yibeichan/reproschema-py that referenced this pull request Feb 6, 2025
@djarecka
Copy link
Member Author

djarecka commented Feb 7, 2025

issues were addressed in #88

@djarecka djarecka closed this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants