Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions reproschema/tests/test_rs2redcap_redcap2rs.py
Original file line number Diff line number Diff line change
Expand Up @@ -259,15 +259,13 @@ def compare_protocols(prot_tree_orig, prot_tree_final):
)

elif key == "isVis":
# Original isVis handling
if orig_value is not None:
if normalize_condition(
orig_value
) != normalize_condition(final_value):
if orig_value is True:
# If original is True and final is None/missing, don't count as error
pass
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still want to have an error when the final value is False

elif orig_value is not None:
if normalize_condition(orig_value) != normalize_condition(final_value):
error = True
elif (
final_value is not None and final_value is not True
):
elif final_value is not None and final_value is not True:
error = True

if error:
Expand Down