-
Notifications
You must be signed in to change notification settings - Fork 9
Fix nan2, isVis, and other errors #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
4b877e5
fix nan, isVis, order issue
yibeichan 2da4919
add test
yibeichan 1b3c488
add test
yibeichan 9ee4529
fix test data error
yibeichan 3dc96da
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] cffaea3
set strip=false
yibeichan eb0eab1
merge from remote
yibeichan 7a6784b
fix normalization condition test error
yibeichan 145e06c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] af55533
fix testing logic for isVis
yibeichan ed01790
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 1b9c1f6
Update reproschema/tests/test_rs2redcap_redcap2rs.py
yibeichan 0f0cba5
fix testing by copy #86 and change isVis logic
yibeichan 77a9ac0
keep local not remote
yibeichan 2caff94
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] c1eb034
add condition when orig_norm is none
yibeichan 70b0adf
Merge branch 'fix-nan2' of github.com:yibeichan/reproschema-py into f…
yibeichan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we still want to have an error when the final value is
False