Tasks 1 and 2 + Style Changes: Adding Audio Input dropdown, AudioVideo, AudioVideoCheck, Video, and VideoCheck components #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on to always put the data, methods, and computed sections first in the export default block.
… blocks inside the export default block are in the same order across different Vue.js files.
Veronika271
changed the title
|
close this one as a new one is open #366 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Vue.js tutorial I watched makes me think that there is a convention is to always organize the export default block with the data, methods and computing sections in that order. Also, I made the props more detailed, according to this style guideline: https://v2.vuejs.org/v2/style-guide/?redirect=true#Priority-A-Essential.