Skip to content

added envrionment variable to simplify switching schemas in UI #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 25, 2025
Merged

added envrionment variable to simplify switching schemas in UI #365

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
684716e
added envrionment variable to simplify switching schemas in UI
bendhouseart Aug 11, 2025
6787b7d
Update src/config.js
bendhouseart Aug 11, 2025
9b31f1b
Update src/config.js
bendhouseart Aug 25, 2025
78646ac
Merge branch 'main' into add-option-for-passing-schema-via-env-var
bendhouseart Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,12 @@
"i18n:report": "vue-cli-service i18n:report --src './src/**/*.?(js|vue)' --locales './src/locales/**/*.json'"
},
"dependencies": {
"@adapttive/vue-markdown": "^4.0.2",
"axios": "^1.7.4",
"bootstrap-vue": "^2.23.1",
"bowser": "^2.11.0",
"core-js": "^3.36.1",
"dotenv": "^17.2.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you introduced the dotenv dependency. Is that what's necessary in this PR to make the process.env.VUE_APP_REPROSCHEMA_GITHUB_SRC work? If not, I would remove it for the sake of a cleaner PR.

"file-saver": "^2.0.5",
"jsonld": "^8.3.2",
"jszip": "^3.10.1",
Expand All @@ -23,7 +25,6 @@
"msr": "^1.3.4",
"vue": "^2.7.16",
"vue-i18n": "^8.28.2",
"@adapttive/vue-markdown": "^4.0.2",
"vue-multiselect": "^2.1.9",
"vue-router": "^3.6.5",
"vue-slider-component": "^3.2.24",
Expand All @@ -33,6 +34,7 @@
"vuex": "^3.6.2"
},
"devDependencies": {
"@babel/eslint-parser": "^7.24.1",
"@intlify/vue-i18n-loader": "^3.3.0",
"@vue/cli-plugin-babel": "^5.0.8",
"@vue/cli-plugin-e2e-cypress": "^5.0.8",
Expand All @@ -42,9 +44,8 @@
"@vue/cli-plugin-vuex": "~5.0.8",
"@vue/cli-service": "^5.0.8",
"@vue/test-utils": "^1.0.3",
"@babel/eslint-parser": "^7.24.1",
"eslint": "^7.32.0",
"cypress": "^13.7.2",
"eslint": "^7.32.0",
"eslint-plugin-vue": "^7.20.0",
"vue-cli-plugin-i18n": "^2.3.2",
"vue-template-compiler": "^2.7.16"
Expand Down
4 changes: 3 additions & 1 deletion src/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module.exports = {
githubSrc: 'https://raw.githubusercontent.com/ReproNim/demo-protocol/main/DemoProtocol/DemoProtocol_schema',
githubSrc: process.env.VUE_APP_REPROSCHEMA_GITHUB_SRC || 'https://raw.githubusercontent.com/ReproNim/demo-protocol/main/DemoProtocol/DemoProtocol_schema',
startButton: {
"en": 'Join',
"es": 'Participar'
Expand All @@ -11,3 +11,5 @@ module.exports = {
contact: '[email protected]',
emailSubject: 'Help with Covid19 study'
};

console.log(`Loading schema from VUE_APP_REPROSCHEMA_GITHUB_SRC: ${process.env.VUE_APP_REPROSCHEMA_GITHUB_SRC}`);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This console.log statement appears to be for debugging. It's best practice to avoid committing such logs, as they can clutter the console in production and might expose internal configuration details. Please remove these lines before merging.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with gemini-code-assist here. Make those two corrections, and you're good to go IMO! I saw your demo this morning to load any schema file from the backend in this more flexible way, and I was happy to see it working.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the confirmation, @ericearl. @bendhouseart, please remove the console.log statement as suggested to finalize this change. Once that's done, this thread can be resolved.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bendhouseart i agree with this one