- 
                Notifications
    
You must be signed in to change notification settings  - Fork 20
 
added envrionment variable to simplify switching schemas in UI #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from 1 commit
      Commits
    
    
            Show all changes
          
          
            4 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      684716e
              
                added envrionment variable to simplify switching schemas in UI
              
              
                bendhouseart 6787b7d
              
                Update src/config.js
              
              
                bendhouseart 9b31f1b
              
                Update src/config.js
              
              
                bendhouseart 78646ac
              
                Merge branch 'main' into add-option-for-passing-schema-via-env-var
              
              
                bendhouseart File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| module.exports = { | ||
| githubSrc: 'https://raw.githubusercontent.com/ReproNim/demo-protocol/main/DemoProtocol/DemoProtocol_schema', | ||
| githubSrc: process.env.VUE_APP_REPROSCHEMA_GITHUB_SRC || 'https://raw.githubusercontent.com/ReproNim/demo-protocol/main/DemoProtocol/DemoProtocol_schema', | ||
| startButton: { | ||
| "en": 'Join', | ||
| "es": 'Participar' | ||
| 
        
          
        
         | 
    @@ -11,3 +11,5 @@ module.exports = { | |
| contact: '[email protected]', | ||
| emailSubject: 'Help with Covid19 study' | ||
| }; | ||
| 
     | 
||
| console.log(`Loading schema from REPROSCHEMA_GITHUB_SRC: ${process.env.VUE_APP_REPROSCHEMA_GITHUB_SRC}`); | ||
                
      
                  bendhouseart marked this conversation as resolved.
               
              
                Outdated
          
            Show resolved
            Hide resolved
         | 
||
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you introduced the
dotenvdependency. Is that what's necessary in this PR to make theprocess.env.VUE_APP_REPROSCHEMA_GITHUB_SRCwork? If not, I would remove it for the sake of a cleaner PR.