Skip to content

add_action: do not auto link the action from RDE mentions #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simleo merged 1 commit into from
Jul 25, 2025
Merged

add_action: do not auto link the action from RDE mentions #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion rocrate/rocrate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,7 +629,6 @@ def add_action(self, instrument, identifier=None, object=None, result=None, prop
action["object"] = object
if result:
action["result"] = result
self.root_dataset.append_to("mentions", action)
return action

def add_formal_parameter(
Expand Down
2 changes: 0 additions & 2 deletions test/test_wrroc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ def test_add_action(tmpdir):
)
assert create_action.type == "CreateAction"
create_actions = crate.get_by_type("CreateAction")
assert crate.root_dataset.get("mentions") == create_actions
assert create_actions == [create_action]
assert create_action.get("instrument") is instrument
assert create_action.get("object") == [f_in, param]
Expand All @@ -74,7 +73,6 @@ def test_add_action(tmpdir):
}
)
assert activate_action.type == "ActivateAction"
assert crate.root_dataset.get("mentions") == [create_action, activate_action]
assert activate_action.get("instrument") is instrument
assert activate_action.get("object") == [f_out]
assert "result" not in activate_action
Expand Down
Loading