doc: packaging: add ELN implementation note in appendix#389
Merged
elichad merged 2 commits intoResearchObject:mainfrom Jan 10, 2025
Merged
doc: packaging: add ELN implementation note in appendix#389elichad merged 2 commits intoResearchObject:mainfrom
elichad merged 2 commits intoResearchObject:mainfrom
Conversation
Add a note about the ELN file format and how it contains a valid RO-Crate inside a ZIP archive.
elichad
requested changes
Jan 10, 2025
Contributor
elichad
left a comment
elichad
left a comment
There was a problem hiding this comment.
Thanks @NicolasCARPi for the contribution! This looks good, just a few minor changes needed for style/formatting
Contributor
Author
|
Hello Eli, Thank you for your review. I have implemented your suggestions in a new commit. |
elichad
approved these changes
Jan 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Please consider adding this note into the documentation :)
Cheers,
~Nicolas