-
Notifications
You must be signed in to change notification settings - Fork 10
Profile updates for RO-Crate 1.2 #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I think we should remove |
thanks, done |
|
from community call: state what version(s) of WROC the WRROC profile is compatible with |
| "name": "Process Run Crate profile", | ||
| "description": "This profile is used to describe the execution of an implicit workflow, indicating that one or more computational tools have been executed, typically generating some result files that are represented as data entities in the RO-Crate.", | ||
| "version": "0.6-DRAFT", | ||
| "datePublished": "2024-06-19", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made these dates the same as the 0.5 publication date for now
|
Recent commit changes:
However, I've just realised that there is a change in 1.2 that has a subtle impact on compatibility here - from the changelog:
Workflow Run and Provenance Run do use those (this actually affects Workflow RO-Crate 1.1 as well thanks to workflowhub-eu/about#87) |
We actually have several occurrences of the full IRIs for $ git grep -F 'https://bioschemas.org/ComputationalWorkflow#input' -- docs/profiles/0.6-DRAFT/
docs/profiles/0.6-DRAFT/provenance_run_crate/example3/ro-crate-preview.html: <th style="text-align:left;" class="prop">input<span> </span><a href="https://bioschemas.org/ComputationalWorkflow#input">[?]</a></th>
docs/profiles/0.6-DRAFT/workflow_run_crate/example2/ro-crate-preview.html: <th style="text-align:left;" class="prop">input<span> </span><a href="https://bioschemas.org/ComputationalWorkflow#input">[?]</a></th>
docs/profiles/0.6-DRAFT/workflow_run_crate/ro-crate-metadata.json: "@id": "https://bioschemas.org/ComputationalWorkflow#input"
docs/profiles/0.6-DRAFT/workflow_run_crate/ro-crate-metadata.json: "@id": "https://bioschemas.org/ComputationalWorkflow#input",
docs/profiles/0.6-DRAFT/workflow_run_crate/ro-crate-preview.html: "@id": "https://bioschemas.org/ComputationalWorkflow#input"
docs/profiles/0.6-DRAFT/workflow_run_crate/ro-crate-preview.html: "@id": "https://bioschemas.org/ComputationalWorkflow#input",
docs/profiles/0.6-DRAFT/workflow_run_crate/ro-crate-preview.html: <h3><a href="https://bioschemas.org/ComputationalWorkflow#input">Go to: </a> input</h3>
docs/profiles/0.6-DRAFT/workflow_run_crate/ro-crate-preview.html: <div id="https://bioschemas.org/ComputationalWorkflow#input">
docs/profiles/0.6-DRAFT/workflow_run_crate/ro-crate-preview.html: <td style='text-align:left'><a href="https://bioschemas.org/ComputationalWorkflow#input">https://bioschemas.org/ComputationalWorkflow#input</a></td>Most notably in the profile crate. So for version 0.6 of the profiles I guess we should declare compatibility with RO-Crate 1.2 only and change the |
Thanks, I think I have fixed these now, though couldn't find the ones below in my local copy (they have the updated IRI for me): |
I agree, I'll implement this tomorrow |
Updates to 0.6-DRAFT:
datePublished,keywords,descriptionto profile crates (keywords are used in the profile registry)isBasedOnfor the workflow-run context to 1.2 - wasn't as sure about this one but the ro-terms repo doesn't seem to declare this at all. I just found Remove reference to RO-Crate context from the JSON(LD) files ro-terms#28 too - is this actually just obsolete and we should removeisBasedOnaltogether?Depends on release of Workflow RO-Crate 1.1.
Fixes #99, fixes #98