Skip to content

Conversation

@ucswift
Copy link
Member

@ucswift ucswift commented Jul 9, 2025

No description provided.

@request-info
Copy link

request-info bot commented Jul 9, 2025

Thanks for opening this, but we'd appreciate a little more information. Could you update it with more details?

@ucswift ucswift requested a review from Copilot July 9, 2025 23:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds functionality for retrieving contact notes and provides a HEAD endpoint for file attachments.

  • Introduces the ContactNotesResult and ContactNoteResultData models.
  • Adds a GetContactNotesByContactId endpoint in ContactsController with conversion logic.
  • Adds a GetFileHead HEAD endpoint in CallFilesController and corresponding XML documentation updates.

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.

File Description
Web/Resgrid.Web.Services/Resgrid.Web.Services.xml Added XML documentation entries for new endpoints/models
Web/Resgrid.Web.Services/Models/v4/Contacts/ContactNotesResult.cs Introduced ContactNotesResult and ContactNoteResultData models
Web/Resgrid.Web.Services/Controllers/v4/ContactsController.cs Added GetContactNotesByContactId method and helper
Web/Resgrid.Web.Services/Controllers/v4/CallFilesController.cs Added GetFileHead HEAD method
Comments suppressed due to low confidence (2)

Web/Resgrid.Web.Services/Resgrid.Web.Services.xml:3393

  • Missing <param name="contactId"> entry in the XML doc. Add a description for the contactId parameter.
        <member name="M:Resgrid.Web.Services.Controllers.v4.ContactsController.GetContactNotesByContactId(System.String)">

Web/Resgrid.Web.Services/Controllers/v4/CallFilesController.cs:134

  • The summary describes fetching a user's avatar, but this method checks file metadata; update the summary to accurately describe GetFileHead behavior.
		/// Get a users avatar from the Resgrid system based on their ID

@ucswift
Copy link
Member Author

ucswift commented Jul 10, 2025

Approve

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is approved.

@ucswift ucswift merged commit ee808d3 into master Jul 10, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants