-
-
Notifications
You must be signed in to change notification settings - Fork 76
Develop #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for opening this, but we'd appreciate a little more information. Could you update it with more details? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds functionality for retrieving contact notes and provides a HEAD endpoint for file attachments.
- Introduces the
ContactNotesResultandContactNoteResultDatamodels. - Adds a
GetContactNotesByContactIdendpoint inContactsControllerwith conversion logic. - Adds a
GetFileHeadHEAD endpoint inCallFilesControllerand corresponding XML documentation updates.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| Web/Resgrid.Web.Services/Resgrid.Web.Services.xml | Added XML documentation entries for new endpoints/models |
| Web/Resgrid.Web.Services/Models/v4/Contacts/ContactNotesResult.cs | Introduced ContactNotesResult and ContactNoteResultData models |
| Web/Resgrid.Web.Services/Controllers/v4/ContactsController.cs | Added GetContactNotesByContactId method and helper |
| Web/Resgrid.Web.Services/Controllers/v4/CallFilesController.cs | Added GetFileHead HEAD method |
Comments suppressed due to low confidence (2)
Web/Resgrid.Web.Services/Resgrid.Web.Services.xml:3393
- Missing
<param name="contactId">entry in the XML doc. Add a description for thecontactIdparameter.
<member name="M:Resgrid.Web.Services.Controllers.v4.ContactsController.GetContactNotesByContactId(System.String)">
Web/Resgrid.Web.Services/Controllers/v4/CallFilesController.cs:134
- The summary describes fetching a user's avatar, but this method checks file metadata; update the summary to accurately describe
GetFileHeadbehavior.
/// Get a users avatar from the Resgrid system based on their ID
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
|
Approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is approved.
No description provided.