CU-8687aj3gt More ios build changes #157
Conversation
WalkthroughUpdated CI workflow to use macos-14 for iOS builds and adjusted quoting in release step. Lowered iOS deployment target in Expo build properties from 18.5 to 18.1. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
app.config.ts (1)
208-209: Confirm intent: iOS deploymentTarget 18.1 drastically narrows device supportSetting deploymentTarget to 18.1 will prevent installs on any device below iOS 18.1 (including 18.0). If this is to align with Xcode/iOS SDK constraints in CI, consider 18.0 to maximize coverage on iOS 18, or a lower baseline (e.g., 16.x/17.x) if you need broader audience support.
If you intended “iOS 18 baseline” without excluding 18.0 devices:
- deploymentTarget: '18.1', + deploymentTarget: '18.0',If broader support is desired (common baselines):
- deploymentTarget: '18.1', + deploymentTarget: '16.0',.github/workflows/react-native-cicd.yml (1)
116-116: macos-14 runner switch is fine; consider pinning Xcode explicitlymacos-14 currently includes Xcode 16.x which is compatible with iOS 18.x SDKs. To avoid future image rotations breaking builds, pin Xcode via setup-xcode.
Example step (after checkout):
- name: 📦 Select Xcode if: matrix.platform == 'ios' uses: maxim-lobanov/setup-xcode@v1 with: xcode-version: '16.2' # adjust to your validated versionNote: Since iOS builds now run on macOS, ensure any Linux-only package installs in subsequent steps have macOS fallbacks (e.g., brew). Your jq check is safe today because jq ships on macOS images, but a portable fallback helps.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
.github/workflows/react-native-cicd.yml(3 hunks)app.config.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{ts,tsx}
📄 CodeRabbit Inference Engine (.cursorrules)
**/*.{ts,tsx}: Write concise, type-safe TypeScript code
Use camelCase for variable and function names (e.g., isFetchingData, handleUserInput)
Use TypeScript for all components, favoring interfaces for props and state
Avoid using any; strive for precise types
Use Expo SecureStore for sensitive data
Use zustand for state management
Use react-query for data fetching and caching
Use react-i18next for internationalization
Use react-native-mmkv for local storage
Use axios for API requests
**/*.{ts,tsx}: Write concise, type-safe TypeScript code
Use camelCase for variable and function names
Use TypeScript for all components, favoring interfaces for props and state
Avoid using any; strive for precise types
Use React Navigation for handling navigation and deep linking
Handle errors gracefully and provide user feedback
Use Expo's SecureStore for sensitive data
Use zustand for state management
Use react-query for data fetching
Use react-i18next for internationalization
Use react-native-mmkv for local storage
Use axios for API requests
Files:
app.config.ts
**/*
📄 CodeRabbit Inference Engine (.cursorrules)
Directory and file names should be lowercase and hyphenated (e.g., user-profile, chat-screen)
Files:
app.config.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: test
🔇 Additional comments (2)
.github/workflows/react-native-cicd.yml (2)
271-273: LGTM: Android-only Firebase distribution conditionThe conditional upload for Android artifacts looks correct and isolated to the Android matrix leg.
309-315: LGTM: Single quotes around expressions are safe in Actions YAMLUsing single quotes for tag, name, artifacts, and bodyFile still allows ${{ }} expressions to evaluate. This change is safe and improves consistency.
|
Approve |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Summary by CodeRabbit