Create internal "Binder" rule#1491
Merged
henriquemoody merged 1 commit intoRespect:mainfrom Dec 12, 2024
Merged
Conversation
There are several cases in which we need to bind the name and template of a rule to another. We need to do that because results need information from rules to be created, and because results come from rules, in some cases, it's not ideal (or possible) to change the information after the result is created.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1491 +/- ##
=========================================
Coverage 97.24% 97.24%
- Complexity 952 953 +1
=========================================
Files 198 198
Lines 2323 2325 +2
=========================================
+ Hits 2259 2261 +2
Misses 64 64 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are several cases in which we need to bind the name and template of a rule to another. We need to do that because results need information from rules to be created, and because results come from rules, in some cases, it's not ideal (or possible) to change the information after the result is created.